[GPU][NFC] Improve error messages. #18948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchetioui
reviewed
Nov 5, 2024
| @@ -1039,7 +1039,7 @@ GemmFusionAutotunerImpl::CompileAll(AutotunerCompileUtil& compile_util, | |||
| absl::StatusOr<bool> has_executable = | |||
| compile(fusion, config, gemm_config_set.size() > 1); | |||
| TF_CHECK_OK(has_executable.status()) | |||
| << "Failure occured when compiling fusion " << fusion->name() | |||
| << " - Failure occured when compiling fusion " << fusion->name() | |||
There was a problem hiding this comment.
Currently it prints without a space, something like "Unknown instructionFailure occured when ...".
bchetioui
approved these changes
Nov 5, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 5, 2024
Imported from GitHub PR openxla/xla#18948 Copybara import of the project: -- 80e717c39e8a120cca974dca9f473d817d3a3457 by Ilia Sergachev <isergachev@nvidia.com>: [GPU][NFC] Improve error messages. Merging this change closes #18948 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18948 from openxla:improve_error_messages 80e717c39e8a120cca974dca9f473d817d3a3457 PiperOrigin-RevId: 693279083
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 5, 2024
…eadable. This CL moves the code that measures the performance of a candidate into a separate function. This makes the code more readable and easier to follow. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18948 from openxla:improve_error_messages 80e717c39e8a120cca974dca9f473d817d3a3457 PiperOrigin-RevId: 692981497
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 5, 2024
…s much as possible. This is particularly useful in FSDP/HSDP where gradient propagation can be done fully in the i+1th iteration. It takes the responsibility of the user to set the `xla_gpu_all_reduce_combine_threshold_bytes` by themselves. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18948 from openxla:improve_error_messages 80e717c39e8a120cca974dca9f473d817d3a3457 PiperOrigin-RevId: 689310865
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 5, 2024
Imported from GitHub PR openxla/xla#18948 Copybara import of the project: -- 80e717c39e8a120cca974dca9f473d817d3a3457 by Ilia Sergachev <isergachev@nvidia.com>: [GPU][NFC] Improve error messages. Merging this change closes #18948 PiperOrigin-RevId: 693291127
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 5, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18948 from openxla:improve_error_messages 80e717c39e8a120cca974dca9f473d817d3a3457 PiperOrigin-RevId: 693242323
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 5, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18948 from openxla:improve_error_messages 80e717c39e8a120cca974dca9f473d817d3a3457 PiperOrigin-RevId: 693295239
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 5, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18948 from openxla:improve_error_messages 80e717c39e8a120cca974dca9f473d817d3a3457 PiperOrigin-RevId: 692583711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.