Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Fix grid dimension issue introduced in d8909c9b8 #19162

Closed
wants to merge 1 commit into from

Conversation

hsharsha
Copy link
Contributor

@hsharsha hsharsha commented Nov 7, 2024

No description provided.

@hsharsha
Copy link
Contributor Author

hsharsha commented Nov 7, 2024

@beckerhe Can you please review this fix. Bug was introduced in d8909c9

@reedwm reedwm requested a review from beckerhe November 8, 2024 01:39
@hsharsha hsharsha force-pushed the ci_fix_gridy_20241107 branch from 9a86838 to dd86f21 Compare November 11, 2024 10:32
Copy link
Member

@beckerhe beckerhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

copybara-service bot pushed a commit that referenced this pull request Nov 12, 2024
Imported from GitHub PR #19162

Copybara import of the project:

--
dd86f21 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Fix grid dimension issue introduced in d8909c9

Merging this change closes #19162

FUTURE_COPYBARA_INTEGRATE_REVIEW=#19162 from ROCm:ci_fix_gridy_20241107 dd86f21
PiperOrigin-RevId: 695258049
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Nov 12, 2024
Imported from GitHub PR openxla/xla#19162

Copybara import of the project:

--
dd86f21a20d1391cefaf6f74f89abce787bb236a by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Fix grid dimension issue introduced in d8909c9b8

Merging this change closes #19162

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19162 from ROCm:ci_fix_gridy_20241107 dd86f21a20d1391cefaf6f74f89abce787bb236a
PiperOrigin-RevId: 695258049
copybara-service bot pushed a commit that referenced this pull request Nov 12, 2024
Imported from GitHub PR #19162

Copybara import of the project:

--
dd86f21 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Fix grid dimension issue introduced in d8909c9

Merging this change closes #19162

FUTURE_COPYBARA_INTEGRATE_REVIEW=#19162 from ROCm:ci_fix_gridy_20241107 dd86f21
PiperOrigin-RevId: 695258049
copybara-service bot pushed a commit that referenced this pull request Nov 12, 2024
Imported from GitHub PR #19162

Copybara import of the project:

--
dd86f21 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Fix grid dimension issue introduced in d8909c9

Merging this change closes #19162

FUTURE_COPYBARA_INTEGRATE_REVIEW=#19162 from ROCm:ci_fix_gridy_20241107 dd86f21
PiperOrigin-RevId: 695258049
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Nov 12, 2024
Imported from GitHub PR openxla/xla#19162

Copybara import of the project:

--
dd86f21a20d1391cefaf6f74f89abce787bb236a by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Fix grid dimension issue introduced in d8909c9b8

Merging this change closes #19162

PiperOrigin-RevId: 695562833
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Nov 12, 2024
Also add a short buffer to the RPC timeouts so that service-related errors may get propagated before the RPC layer times it out.

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19162 from ROCm:ci_fix_gridy_20241107 dd86f21a20d1391cefaf6f74f89abce787bb236a
PiperOrigin-RevId: 695513899
mmakevic-amd added a commit to ROCm/tensorflow-upstream that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants