-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Fix grid dimension issue introduced in d8909c9b8 #19162
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsharsha
force-pushed
the
ci_fix_gridy_20241107
branch
from
November 11, 2024 10:32
9a86838
to
dd86f21
Compare
beckerhe
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Imported from GitHub PR #19162 Copybara import of the project: -- dd86f21 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Fix grid dimension issue introduced in d8909c9 Merging this change closes #19162 FUTURE_COPYBARA_INTEGRATE_REVIEW=#19162 from ROCm:ci_fix_gridy_20241107 dd86f21 PiperOrigin-RevId: 695258049
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 12, 2024
Imported from GitHub PR openxla/xla#19162 Copybara import of the project: -- dd86f21a20d1391cefaf6f74f89abce787bb236a by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Fix grid dimension issue introduced in d8909c9b8 Merging this change closes #19162 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19162 from ROCm:ci_fix_gridy_20241107 dd86f21a20d1391cefaf6f74f89abce787bb236a PiperOrigin-RevId: 695258049
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Imported from GitHub PR #19162 Copybara import of the project: -- dd86f21 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Fix grid dimension issue introduced in d8909c9 Merging this change closes #19162 FUTURE_COPYBARA_INTEGRATE_REVIEW=#19162 from ROCm:ci_fix_gridy_20241107 dd86f21 PiperOrigin-RevId: 695258049
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Imported from GitHub PR #19162 Copybara import of the project: -- dd86f21 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Fix grid dimension issue introduced in d8909c9 Merging this change closes #19162 FUTURE_COPYBARA_INTEGRATE_REVIEW=#19162 from ROCm:ci_fix_gridy_20241107 dd86f21 PiperOrigin-RevId: 695258049
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 12, 2024
Imported from GitHub PR openxla/xla#19162 Copybara import of the project: -- dd86f21a20d1391cefaf6f74f89abce787bb236a by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Fix grid dimension issue introduced in d8909c9b8 Merging this change closes #19162 PiperOrigin-RevId: 695562833
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 12, 2024
Also add a short buffer to the RPC timeouts so that service-related errors may get propagated before the RPC layer times it out. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19162 from ROCm:ci_fix_gridy_20241107 dd86f21a20d1391cefaf6f74f89abce787bb236a PiperOrigin-RevId: 695513899
mmakevic-amd
added a commit
to ROCm/tensorflow-upstream
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.