Add yet another candidate for CUDA root #20858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUDA root is quite commonly located at `/opt/cuda`. Some linux distros like Archlinux installs CUDA to `/opt/cuda`. Additionally, some build systems like CMake uses this candidate for CUDA home as well.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ybaturina
approved these changes
Dec 27, 2024
|
Is there any chance that this PR will merged or at least reviewed? |
medaminezghal
approved these changes
Jan 2, 2025
medaminezghal
approved these changes
Jan 2, 2025
|
Hi @daskol a lot of people were on holidays. I'll try to merge this PR as soon as I get approval. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 2, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 2, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
|
Thank you for the update! I appreciate your effort and look forward to the merge when it's ready. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 3, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 3, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711428469
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711818748
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 3, 2025
Add alternative CUDA root that is used in some systems. PiperOrigin-RevId: 711818748
|
Hi, this change was submitted in another PR - tensorflow/tensorflow@f3f10af |
|
Should I do anything else? I noticed and was very surprised that TF fully vendors XLA. |
|
Hi @daskol no, no further actions needed. |
|
Should I close this pull request? I noticed that PR #20971 and tensorflow/tensorflow#84029 have already been merged. |
|
Hi @daskol. Yes, you can close it. |
|
Great! Thank you for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ybaturina Take a look at this pull please. It solves the issue with hermetic CUDA builds and CUDA root at
/opt/cudaon some distros.CUDA root is quite commonly located at
/opt/cuda./opt/cuda[1].