Propagate loop metadata in double_buffer_loop_unrolling. #25275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@golechwierowicz Might make sense for you to look at this one :-) Thanks! |
golechwierowicz
approved these changes
Apr 22, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR #25275 Currently, this pass drops the `known_induction_variable` and `known_init_step` fields in `WhileLoopBackendConfig`. This change keeps them if they were present before and updates them with the updated value, just like `known_trip_count`. This is only done for double buffered loops, not for fully unrolled ones. Copybara import of the project: -- 6bd4459 by Johannes Reifferscheid <jreiffers@nvidia.com>: Keep loop metadata after loop unrolling. -- 369ad9b by Johannes Reifferscheid <jreiffers@nvidia.com>: Fix init update and add tests. Merging this change closes #25275 FUTURE_COPYBARA_INTEGRATE_REVIEW=#25275 from jreiffers:keep-metadata 369ad9b PiperOrigin-RevId: 750112934
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR openxla/xla#25275 Currently, this pass drops the `known_induction_variable` and `known_init_step` fields in `WhileLoopBackendConfig`. This change keeps them if they were present before and updates them with the updated value, just like `known_trip_count`. This is only done for double buffered loops, not for fully unrolled ones. Copybara import of the project: -- 6bd44597c2e1dba443a367edf4a21024f6248cb6 by Johannes Reifferscheid <jreiffers@nvidia.com>: Keep loop metadata after loop unrolling. -- 369ad9bedd031d1e1fd6abacb7a5002f290c72f2 by Johannes Reifferscheid <jreiffers@nvidia.com>: Fix init update and add tests. Merging this change closes #25275 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25275 from jreiffers:keep-metadata 369ad9bedd031d1e1fd6abacb7a5002f290c72f2 PiperOrigin-RevId: 750112934
Closed
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25275 from jreiffers:keep-metadata 369ad9bedd031d1e1fd6abacb7a5002f290c72f2 PiperOrigin-RevId: 749967019
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25275 from jreiffers:keep-metadata 369ad9bedd031d1e1fd6abacb7a5002f290c72f2 PiperOrigin-RevId: 749972843
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 22, 2025
Imported from GitHub PR openxla/xla#25275 Currently, this pass drops the `known_induction_variable` and `known_init_step` fields in `WhileLoopBackendConfig`. This change keeps them if they were present before and updates them with the updated value, just like `known_trip_count`. This is only done for double buffered loops, not for fully unrolled ones. Copybara import of the project: -- 6bd44597c2e1dba443a367edf4a21024f6248cb6 by Johannes Reifferscheid <jreiffers@nvidia.com>: Keep loop metadata after loop unrolling. -- 369ad9bedd031d1e1fd6abacb7a5002f290c72f2 by Johannes Reifferscheid <jreiffers@nvidia.com>: Fix init update and add tests. Merging this change closes #25275 PiperOrigin-RevId: 750122105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this pass drops the
known_induction_variableandknown_init_stepfields inWhileLoopBackendConfig. This change keeps them if they were present before and updates them with the updated value, just likeknown_trip_count. This is only done for double buffered loops, not for fully unrolled ones.