Merge pull request #283 from SataQiu/fix-20210427

bugfix: fix the bug that dns controller updates dns records incorrectly
openyurtio · Apr 27, 2021 · 08da18d · 08da18d
2 parents 39f1bac + f04bc93
commit 08da18d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/yurttunnel/dns/dns.go b/pkg/yurttunnel/dns/dns.go
@@ -334,7 +334,7 @@ func (dnsctl *coreDNSRecordController) syncDNSRecordAsWhole() {
 	dnsctl.lock.Lock()
 	defer dnsctl.lock.Unlock()
 
-	ip, err := dnsctl.getTunnelServerIP(false)
+	tunnelServerIP, err := dnsctl.getTunnelServerIP(false)
 	if err != nil {
 		klog.Errorf("failed to sync dns record as whole, %v", err)
 		return
@@ -348,7 +348,7 @@ func (dnsctl *coreDNSRecordController) syncDNSRecordAsWhole() {
 
 	records := make([]string, 0, len(nodes))
 	for i := range nodes {
-		node := nodes[i]
+		ip, node := tunnelServerIP, nodes[i]
 		if !isEdgeNode(node) {
 			ip, err = getNodeHostIP(node)
 			if err != nil {