Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add 'yurthub-healthcheck-timeout' flag for 'yurtctl convert' command #290

Merged
merged 1 commit into from
May 7, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented May 6, 2021

Ⅰ. Describe what this PR does

Feature: add yurthub-healthcheck-timeout flag for yurtctl convert command.
This PR makes the Yurthub health-check timeout configurable for extreme scenarios, such as slow image downloads.

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

yurtctl convert

Ⅴ. Special notes for reviews

@SataQiu SataQiu force-pushed the support-hub-timeout branch from 1ada0b9 to 576b9d4 Compare May 6, 2021 11:53
… command

Signed-off-by: SataQiu <1527062125@qq.com>
@SataQiu SataQiu force-pushed the support-hub-timeout branch from 576b9d4 to c99c985 Compare May 7, 2021 03:20
@charleszheng44 charleszheng44 merged commit d61c30c into openyurtio:master May 7, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
… command (openyurtio#290)

Signed-off-by: SataQiu <1527062125@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants