Add subcommand join to yurtctl. #387
Conversation
|
@zyjhtangtang: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zyjhtangtang please fix the code conflicts. |
pkg/yurtctl/cmd/join/join.go
Outdated
| ) | ||
| flagSet.StringVar( | ||
| &joinOptions.yurthubImage, "yurthub-image", "", | ||
| "Sets the node is edge-node or cloud-node", |
There was a problem hiding this comment.
--> Sets the image version of yurthub component
| kubernetsBridgeSetting = `net.bridge.bridge-nf-call-ip6tables = 1 | ||
| net.bridge.bridge-nf-call-iptables = 1` | ||
| tmpDownloadDir = "/tmp" | ||
| yurtHubStaticPodYamlFile = "/etc/kubernetes/manifests/edge-hub-dp.yaml" |
There was a problem hiding this comment.
edge-hub-dp.yaml --> yurthub.yaml
| } | ||
| if err := apiclient.PatchNode(client, cfg.NodeRegistration.Name, func(n *v1.Node) { | ||
| n.Labels[projectinfo.GetEdgeWorkerLabelKey()] = "true" | ||
| n.Labels[projectinfo.GetEdgeEnableTunnelLabelKey()] = "true" |
There was a problem hiding this comment.
"openyurt.io/edge-enable-reverseTunnel-client" label is deprecated.
|
@zyjhtangtang Would you add some tutorial document of yurtctl join command? |
zyjhtangtang
force-pushed
the
master
branch
3 times, most recently
from
066bb5b
to
38bcb96
Compare
|
Overall, I think it’s good, at least before the test. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, zyjhtangtang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add subcommand join to yurtctl, reference proposal https://github.com/openyurtio/openyurt/blob/master/docs/proposals/20210607-adding-subcommands-server-join-reset-for-yurtctl.md
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note