optimize yurttunnel server deployment and yurt app manager deployment… #435
Conversation
… yaml for system arch, not write for amd64 forever
|
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/yurtctl/cmd/convert/convert.go
Outdated
| @@ -141,6 +143,8 @@ func NewConvertCmd() *cobra.Command { | |||
| cmd.Flags().String("yurt-app-manager-image", | |||
| "openyurt/yurt-app-manager:v0.4.0", | |||
| "The yurt-app-manager image.") | |||
| cmd.Flags().String("system-architecture", "amd64", | |||
| "The system architecture of program execution.") | |||
There was a problem hiding this comment.
I think that system-architecture of node is used by yurt-app-manager and yurt-tunnel-server, not by all of program execution. so the help information should be modified as following maybe more reasonable.
The system architecture of program execution --> The system architecture of cloud nodes
There was a problem hiding this comment.
sounds greate and more correct
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JameKeal welcome you to apply OpenYurt community member. you can reference the apply example here: openyurtio/community#15 |
openyurtio#435) * optimize yurttunnel server deployment and yurt app manager deployment yaml for system arch, not write for amd64 forever * Add a new parameter for yurtctl to control the system architecture * help information describe more correct
… yaml for system arch, not write for amd64 forever
What type of PR is this?
/kind feature
What this PR does / why we need it:
optimize yurttunnel server deployment and yurt app manager deployment yaml for system arch, not write for amd64 forever.
Now write the "beta.kubernetes.io/arch: amd64" in yurt-tunnel-server-tmpl.go and yurt-app-manager-tmpl.go, when i want to deploy arm64 linux, must to change the label to arm64, It's too complicated.
This PR use parameter to fill the yaml file, Dynamically retrieved at run time
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note