Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add check-license-header script to github action #487

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

lonelyCZ
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature

What this PR does / why we need it:

  1. add hack script to check newly created files that license header missed or not.
  2. revise github actions to include this hack script.

Which issue(s) this PR fixes:

Fixes #478

Special notes for your reviewer:

I am not sure where the github action should be, but I think it should be in front. Because if the license header missed in files, the following test steps need not to be performed.

Does this PR introduce a user-facing change?

NONE

other Note

@openyurt-bot
Copy link
Collaborator

@lonelyCZ: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature

What this PR does / why we need it:

  1. add hack script to check newly created files that license header missed or not.
  2. revise github actions to include this hack script.

Which issue(s) this PR fixes:

Fixes #478

Special notes for your reviewer:

I am not sure where the github action should be, but I think it should be in front. Because if the license header missed in files, the following test steps need not to be performed.

Does this PR introduce a user-facing change?

NONE

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Sep 22, 2021
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Sep 22, 2021
@openyurt-bot
Copy link
Collaborator

Welcome @lonelyCZ! It looks like this is your first PR to openyurtio/openyurt 🎉

@lonelyCZ
Copy link
Member Author

/assign @rambohe-ch

@rambohe-ch
Copy link
Member

@lonelyCZ I agree with you that put license check at the begin of github actions.

/lgtm
/approve

@openyurt-bot openyurt-bot added lgtm lgtm approved approved labels Sep 23, 2021
@rambohe-ch
Copy link
Member

@lonelyCZ Welcome you to apply OpenYurt community member, and you can add me as sponsor. here is a apply example: openyurtio/community#28

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lonelyCZ, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit 32df8c2 into openyurtio:master Sep 23, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
feature: add check-license-header script to github action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]add hack script to check license header for newly created files.
3 participants