Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update yurtcluster definition #518

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Oct 12, 2021

What type of PR is this?

/kind documentation
/kind design

What this PR does / why we need it:

  • add common ExtraArgs field into ComponentConfig
  • split YurtHubSpec into Cloud and Edge to support install YurtHub on both cloud and edge nodes with different flags.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @Fei-Guo @rambohe-ch

Does this PR introduce a user-facing change?

NONE

other Note

@Fei-Guo
Copy link
Member

Fei-Guo commented Oct 12, 2021

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 12, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Oct 12, 2021
@openyurt-bot openyurt-bot merged commit d88528e into openyurtio:master Oct 12, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/design kind/design kind/documentation kind/documentation lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants