-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yurthub verify bootstrap ca on start #631
Conversation
@gnunu: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
45d0618
to
3fa1ecd
Compare
@gnunu A good job to remove pki based on verifying join token. please fix the above golangci lint error. |
3fa1ecd
to
1f0dc41
Compare
@rambohe-ch thanks! |
@gnunu I think that maybe we can compare the remote server address from yurthub startup parameter |
a126ce1
to
9af9bc1
Compare
…leanup if necessary
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnunu, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…leanup if necessary (openyurtio#631)
What type of PR is this?
/kind bug
What this PR does / why we need it:
verify existed ca file if any, and do cleanup if necessary (mismatch). This will fix the openyurt convert failure due to stale contents left over in the yurthub root dir (/var/lib/yurthub).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note