Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "k8s.io/kubernetes/pkg/controller/apis/config" dependency for yurt-controller-manager #664

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

qclc
Copy link
Member

@qclc qclc commented Dec 8, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

  • Remove "k8s.io/kubernetes/pkg/controller/apis/config" dependency for yurt-controller-manager.
  • The k8s.io/controller-manager only supports version 1.20.x or later. The current policy is to cache the used k8s.io/kubernetes/pkg/controller/apis/config/types.go file. After openYurt is upgraded to version 1.20.x, I will submit a PR to replace k8s.io/kubernetes/pkg/controller with k8s.io/controller-manager.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@qclc: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

  • Remove "k8s.io/kubernetes/pkg/controller/apis/config" dependency for yurt-controller-manager.
  • The k8s.io/controller-manager only supports version 1.20.x or later. The current policy is to cache the used k8s.io/kubernetes/pkg/controller/apis/config/types.go file. After openYurt is upgraded to version 1.20.x, I will submit a PR to replace k8s.io/kubernetes/pkg/controller with k8s.io/controller-manager.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qclc, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Dec 8, 2021
@openyurt-bot openyurt-bot merged commit 2677344 into openyurtio:master Dec 8, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants