Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for yurthub data filtering framework #670

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

windydayc
Copy link
Member

@windydayc windydayc commented Dec 10, 2021

What type of PR is this?

/kind good-first-issue
/kind feature

What this PR does / why we need it:

Data filtering framework is an elegant feature of yurthub, but it lacks unit tests.

Which issue(s) this PR fixes:

Fixes #418

Special notes for your reviewer:

/assign @rambohe-ch

@openyurt-bot
Copy link
Collaborator

@windydayc: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind good-first-issue
/kind feature

What this PR does / why we need it:

Data filtering framework is elegant feature of yurthub, but it lacks unit tests.

Which issue(s) this PR fixes:

Fixes #418

Special notes for your reviewer:

/assign @rambohe-ch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Improve the test cases coverage of yurthub component.

Closes openyurtio#418
@openyurt-bot openyurt-bot added the approved approved label Dec 10, 2021
@rambohe-ch
Copy link
Member

@windydayc Very appreciate for adding test case for data filter framework of yurthub, it's a good job.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Dec 10, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, windydayc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 630d295 into openyurtio:master Dec 10, 2021
@windydayc windydayc deleted the add_unit_test branch December 10, 2021 09:03
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Improve the test cases coverage of yurthub component.

Closes openyurtio#418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature kind/good-first-issue kind/good-first-issue lgtm lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yurthub] add unit test cases for data filtering framework
3 participants