-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] adapt k8s v1.22 version #809
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Congrool @huiwq1990 |
@rambohe-ch I think we have some works to do with k8s1.22, like: unittest still use kind 1.21. How to contribute it? |
After some check, I found why the unit test run failed. It's because the [root@hg vagrant]# kubectl get csr
NAME AGE SIGNERNAME REQUESTOR CONDITION
csr-lfkbn 5m13s kubernetes.io/kube-apiserver-client-kubelet system:bootstrap:abcdef Approved,Issued
csr-n8f25 2m58s kubernetes.io/kube-apiserver-client system:bootstrap:abcdef Approved,Issued
csr-rhtnp 88s kubernetes.io/kubelet-serving system:node:openyurt-e2e-test-worker Approved,Issued
csr-vxtrg 28s kubernetes.io/kube-apiserver-client system:bootstrap:abcdef Pending
csr-zsztg 4m19s kubernetes.io/kube-apiserver-client system:node:openyurt-e2e-test-worker Approved,Issued We can manually approve them use command below. kubectl get csr -o go-template --template='{{range .items}}{{.metadata.name}}{{"\n"}}{{end}}' | xargs -n 1 kubectl certificate approve As far as I know, we want to generate cert for edgenode, but apiserver need approve the csr before generate cert. Auto approve csr maybe the easiest way to solve it. |
@huiwq1990 One point we need to concern: |
The k8s v1.22 feature is on branch |
@huiwq1990 Well, there're serval ways for cooperation on Github.
|
@rambohe-ch @Congrool Hi, I just finish adapt k8s 1.22 and create a pull request #821. My work is base on your code. What's your suggestion use which branch? |
74196f3
to
d687d3a
Compare
d687d3a
to
fb05864
Compare
@huiwq1990 @Congrool OpenYurt for K8s v1.22.3 adaption has been completed. please take a look. |
Do we mainly focus on this pr, what about #821? @rambohe-ch @huiwq1990 |
@Congrool yes, i had contacted with @huiwq1990 , we will use this pr to adapt k8s v1.22 for OpenYurt. |
fb05864
to
4a2e036
Compare
4a2e036
to
ad33a5a
Compare
ad33a5a
to
3f9328d
Compare
@rambohe-ch we should push other project adapt k8s 1.22 too ,like openyurtio/yurt-app-manager#49. |
/lgtm |
Fixes #734 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Congrool, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #734 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
adapt k8s v1.22.3 version for OpenYurt components, the main work as following:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note