Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the panic when the active endpoints of gateway is nil/empty #180

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

River-sh
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 16.90%. Comparing base (7cd6b50) to head (d86de52).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/proxyengine/proxyserver/manageheader.go 46.66% 6 Missing and 2 partials ⚠️
pkg/proxyengine/proxyserver/interceptor.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   15.94%   16.90%   +0.96%     
==========================================
  Files          33       33              
  Lines        4315     4324       +9     
==========================================
+ Hits          688      731      +43     
+ Misses       3465     3427      -38     
- Partials      162      166       +4     
Flag Coverage Δ
unittests 16.90% <41.17%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YTGhost YTGhost merged commit 2b153e5 into openyurtio:main Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants