Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle DeletedFinalStateUnknown in deleteGateway #75

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

jellor
Copy link
Contributor

@jellor jellor commented Nov 13, 2022

As described in ResourceEventHandler comments, it maybe will get an object of type DeletedFinalStateUnknown in deleteGateway. so should handle this case.

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #75 (f69371b) into main (57d026a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   45.59%   45.59%           
=======================================
  Files           7        7           
  Lines         805      805           
=======================================
  Hits          367      367           
  Misses        386      386           
  Partials       52       52           
Flag Coverage Δ
unittests 45.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@njucjc
Copy link
Member

njucjc commented Nov 14, 2022

can you provide some background to the problem ?

@njucjc njucjc merged commit f9ad2fa into openyurtio:main Nov 14, 2022
@jellor jellor deleted the delete-gateway branch November 14, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants