Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Fix a bug. A node'label will be deleted if it deleted from a nodepool… #42

Closed
wants to merge 1 commit into from

Conversation

chenyufeifei
Copy link

@chenyufeifei chenyufeifei commented Mar 10, 2022

… that has the same label

#41

I add an annotation to record the node'label and annotations and taints.
When I need to delete the node from a nodePool. I will change the node' attribute according to this annotation.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@chenyufeifei: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

… that has the same label

I add an annotation to record the node'label and annotations and taints.
When I need to delete the node from a nodePool. I will change the node' attribute according to this annotation.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenyufeifei
To complete the pull request process, please assign charleszheng44
You can assign the PR to them by writing /assign @charleszheng44 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Mar 10, 2022
@openyurt-bot
Copy link
Collaborator

Welcome @chenyufeifei! It looks like this is your first PR to openyurtio/yurt-app-manager 🎉

@chenyufeifei
Copy link
Author

/assign @charleszheng44

@rambohe-ch
Copy link
Member

/assign @kadisi @zzguang

@rambohe-ch
Copy link
Member

@chenyufeifei please rebase the conflicting files.

@charleszheng44 charleszheng44 removed their assignment May 22, 2023
@rambohe-ch rambohe-ch closed this Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants