add workflow ci for yurt-app-manager #72

rambohe-ch · 2022-07-19T08:34:34Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

add ci workflow for yut-app-manager

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot · 2022-07-19T08:34:40Z

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

add ci workflow for yut-app-manager

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?
other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rambohe-ch · 2022-07-19T08:34:55Z

/assign @huiwq1990 @Congrool

openyurt-bot · 2022-07-19T08:35:02Z

@rambohe-ch: GitHub didn't allow me to assign the following users: huiwq1990, congrool.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @huiwq1990 @Congrool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2022-07-19T11:40:29Z

Codecov Report

❗ No coverage uploaded for pull request base (master@7b35094). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #72   +/-   ##
========================================
  Coverage          ?   7.78%           
========================================
  Files             ?      17           
  Lines             ?    1901           
  Branches          ?       0           
========================================
  Hits              ?     148           
  Misses            ?    1724           
  Partials          ?      29

Flag	Coverage Δ
unittests	`7.78% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

huiwq1990 · 2022-07-19T15:18:09Z

.github/workflows/ci.yaml

+jobs:
+
+  check-license:
+    if: github.repository == 'openyurtio/yurt-app-manager'


Why add the if check?

only check openyurtio/yurt-app-manager repo, skip repos like rambohe-ch/yurt-app-manager

I think it's better for contributors to trigger the github actions on their own forked repo to debug first before submitting a pr to the openyurt repo.

I think it's better for contributors to trigger the github actions on their own forked repo to debug first before submitting a pr to the openyurt repo.

Yes, I agree.

Congrool · 2022-07-20T05:50:13Z

Makefile

@@ -115,6 +114,9 @@ GOLANGCI_LINT = $(shell pwd)/bin/golangci-lint
 golangci-lint: ## Download golangci-lint locally if necessary.
 	$(call go-get-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/cmd/golangci-lint@v1.42.1)

+lint: golangci-lint ## Run go lint against code.
+	$(GOLANGCI_LINT) run -v


It seems that we will install golangci-lint@1.42.1.
But we run golangci-lint@1.31.1 in github actions.
We should make them the same version.

Congrool · 2022-07-20T05:55:09Z

pkg/yurtappmanager/util/refmanager/ref_manager_test.go

@@ -17,6 +17,7 @@ limitations under the License.

 package refmanager

+/*


Why we comment all this file?

all of unit test cases can not pass, and i can not fix in a short time. so comment it temporarily.

Could we create an issue to trace it?

@Congrool yes, we are improving unit tests of yurt-app-manager now, so new test cases will be added soon.

Well, I mean we can currently create an issue as a memo about the left problems of this pr, to avoid forgeting it.
Currently, we comment

yurtappset_controller_test.go

ref_manager_test.go

And when we finally complete these problems, we can close this issue.

Congrool · 2022-07-25T08:10:18Z

/lgtm

openyurt-bot · 2022-07-25T08:10:29Z

@Congrool: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openyurt-bot · 2022-07-25T08:13:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rambohe-ch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openyurt-bot added the kind/enhancement kind/enhancement label Jul 19, 2022

openyurt-bot requested review from Fei-Guo and kadisi July 19, 2022 08:34

openyurt-bot added the approved approved label Jul 19, 2022

openyurt-bot added the size/L size/L: 100-499 label Jul 19, 2022

rambohe-ch force-pushed the add-ci-workflow branch 2 times, most recently from 3418814 to 55345b3 Compare July 19, 2022 11:35

openyurt-bot added size/XL and removed size/L size/L: 100-499 labels Jul 19, 2022

rambohe-ch force-pushed the add-ci-workflow branch 3 times, most recently from a75342b to b4f8c92 Compare July 19, 2022 12:00

huiwq1990 reviewed Jul 19, 2022

View reviewed changes

Congrool reviewed Jul 20, 2022

View reviewed changes

add workflow ci for yurt-app-manager

7db4e60

rambohe-ch force-pushed the add-ci-workflow branch from b4f8c92 to 7db4e60 Compare July 25, 2022 06:58

Congrool approved these changes Jul 25, 2022

View reviewed changes

Congrool merged commit fe8491b into openyurtio:master Jul 25, 2022

This was referenced Jul 25, 2022

[unit test] improve unit test coverage for yurtappset #74

Closed

[unit test] fix unit tests in ref_manager_test.go #80

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add workflow ci for yurt-app-manager #72

add workflow ci for yurt-app-manager #72

rambohe-ch commented Jul 19, 2022

openyurt-bot commented Jul 19, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

rambohe-ch commented Jul 19, 2022

openyurt-bot commented Jul 19, 2022

codecov bot commented Jul 19, 2022 •

edited

Loading

huiwq1990 Jul 19, 2022

rambohe-ch Jul 20, 2022

Congrool Jul 20, 2022

huiwq1990 Jul 23, 2022

rambohe-ch Jul 25, 2022

Congrool Jul 20, 2022

rambohe-ch Jul 20, 2022

Congrool Jul 20, 2022

rambohe-ch Jul 20, 2022

Congrool Jul 25, 2022

rambohe-ch Jul 25, 2022

Congrool Jul 25, 2022

Congrool commented Jul 25, 2022

openyurt-bot commented Jul 25, 2022

openyurt-bot commented Jul 25, 2022

		@@ -17,6 +17,7 @@ limitations under the License.

		package refmanager

		/*

add workflow ci for yurt-app-manager #72

add workflow ci for yurt-app-manager #72

Conversation

rambohe-ch commented Jul 19, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot commented Jul 19, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

rambohe-ch commented Jul 19, 2022

openyurt-bot commented Jul 19, 2022

codecov bot commented Jul 19, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Congrool commented Jul 25, 2022

openyurt-bot commented Jul 25, 2022

openyurt-bot commented Jul 25, 2022

codecov bot commented Jul 19, 2022 •

edited

Loading