Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

validate and mutate webhook upgrade #88

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

huiwq1990
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

  1. upgrade controller-runtime version
  2. webhook code testable

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

  1. upgrade controller-runtime version
  2. webhook code testable

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #88 (32953f7) into master (8d865d2) will increase coverage by 7.90%.
The diff coverage is 49.50%.

❗ Current head 32953f7 differs from pull request most recent head 7f76e05. Consider uploading reports for the commit 7f76e05 to get more accurate results

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage    7.78%   15.69%   +7.90%     
==========================================
  Files          17       20       +3     
  Lines        1901     2498     +597     
==========================================
+ Hits          148      392     +244     
- Misses       1724     2037     +313     
- Partials       29       69      +40     
Flag Coverage Δ
unittests 15.69% <49.50%> (+7.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../webhook/yurtappdaemon/yurtappdaemon_validation.go 47.36% <ø> (ø)
...anager/webhook/yurtappset/yurtappset_validation.go 44.64% <ø> (ø)
...ger/webhook/yurtappdaemon/yurtappdaemon_webhook.go 46.00% <46.00%> (ø)
...ppmanager/webhook/yurtappset/yurtappset_webhook.go 52.94% <52.94%> (ø)
...r/controller/yurtingress/yurtingress_controller.go 17.64% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Congrool
Copy link
Member

Congrool commented Aug 3, 2022

Fixes #78

@huiwq1990 huiwq1990 force-pushed the feat-webhook2 branch 3 times, most recently from a7db001 to 57f3251 Compare August 4, 2022 02:17
Signed-off-by: huiwq1990 <huiwq1990@163.com>
@huiwq1990
Copy link
Member Author

@Congrool @rambohe-ch

@Congrool
Copy link
Member

Congrool commented Aug 6, 2022

Thanks for your contribution.
But I'm not familiar with how to generate webhook with controller-runtime. It will take some time.
Anyone else that can help review this pr is also welcome.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit 1b8e724 into openyurtio:master Aug 8, 2022
@huiwq1990 huiwq1990 deleted the feat-webhook2 branch October 1, 2022 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants