-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @kadisi |
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 7.78% 15.36% +7.57%
==========================================
Files 17 18 +1
Lines 1901 1953 +52
==========================================
+ Hits 148 300 +152
+ Misses 1724 1617 -107
- Partials 29 36 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luc99hen, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # #73
Special notes for your reviewer:
This PR add unit tests for nodepool controller and some related utils function. To improve the test coverage, some controller code are refactored for better testability.
Does this PR introduce a user-facing change?
no
other Note