Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

enable ci to verify go.mod #94

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

Congrool
Copy link
Member

@Congrool Congrool commented Aug 6, 2022

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Currently, we have no way to check if go.mod in a pr has been tidied.
We should do that to make sure all pr has run go mod tidy before being merged.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Currently, we have no way to check if go.mod in a pr has been tidied.
We should do that to make sure all pr has run go mod tidy before being merged.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Aug 6, 2022
@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Aug 6, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #94 (8e8ad2d) into master (23956e8) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #94   +/-   ##
======================================
  Coverage    9.34%   9.34%           
======================================
  Files          18      18           
  Lines        2258    2258           
======================================
  Hits          211     211           
  Misses       2010    2010           
  Partials       37      37           
Flag Coverage Δ
unittests 9.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rambohe-ch
Copy link
Member

rambohe-ch commented Aug 8, 2022

@Congrool It's a good idea to check go mod for pull request, maybe we can also add this feature for other repos.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 8, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit 1483bac into openyurtio:master Aug 8, 2022
@Congrool
Copy link
Member Author

Congrool commented Aug 8, 2022

@Congrool It's a good idea to check go mod for pull request, maybe we can also add this feature for other repos.

Sure, I'll add it to openyurt repo as well.

@Congrool Congrool deleted the verify-mod branch August 8, 2022 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants