Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

readd yurtingress webhook #98

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

huiwq1990
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot requested review from Fei-Guo and kadisi August 10, 2022 01:20
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Aug 10, 2022
@rambohe-ch
Copy link
Member

@huiwq1990 please fix the ci pipeline's errors.

Signed-off-by: huiwq1990 <huiwq1990@163.com>
@openyurt-bot openyurt-bot added size/M size/M: 30-99 and removed size/XS size/XS: 0-9 labels Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #98 (3acb802) into master (86623fb) will increase coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   21.33%   21.87%   +0.54%     
==========================================
  Files          21       23       +2     
  Lines        2550     2647      +97     
==========================================
+ Hits          544      579      +35     
- Misses       1930     1986      +56     
- Partials       76       82       +6     
Flag Coverage Δ
unittests 21.87% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...manager/webhook/yurtingress/yurtingress_webhook.go 24.44% <0.00%> (ø)
...ager/webhook/yurtingress/yurtingress_validating.go 46.15% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the approved approved label Aug 10, 2022
@rambohe-ch rambohe-ch merged commit aaeca3e into openyurtio:master Aug 10, 2022
@huiwq1990 huiwq1990 deleted the bugfix-yurtingress branch August 12, 2022 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved approved size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants