Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jammy #2

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Upgrade to jammy #2

merged 1 commit into from
Nov 9, 2021

Conversation

xnox
Copy link
Contributor

@xnox xnox commented Nov 3, 2021

Upgrade to libabigail 2.0 from Ubuntu Jammy (to become 22.04 LTS / the next LTS)

@xnox xnox marked this pull request as draft November 3, 2021 12:38
@gmelikov
Copy link
Member

gmelikov commented Nov 3, 2021

Could you please describe what's the purpose of version upgrade?

We're interested to have a minimal version requirement too for local runs.

@xnox
Copy link
Contributor Author

xnox commented Nov 3, 2021

Could you please describe what's the purpose of version upgrade?

We're interested to have a minimal version requirement too for local runs.

It's a notification that a new upstream release of libabigail breaks zfs abi checks. Meaning we now have a maximum supported version of 0.8.x.

I am upgrading zfs in development release of Ubuntu jammy / 22.04 which has the new libabigail. The development release of Ubuntu will have a newer libabigail which seems to want different format of abi files and doesn't accept the current ones. Obviously most distributions will pick up the new libabigail soon and would want to build zfs 2.1.1 and/or newer releases. Thus this is a canary notification in a way, that this somehow needs to be resolved. I.e. skipping abi checks if abigail is 2.0 or maintaining two abi files for 0.8 and 2.0; or upgrading the minimum required libabigail to 2.0.

I did this proposal, to preview the zfs change inside a workflow run. (workflow failed redoing it)

I wonder if we need to build & vendor both 0.8 and 2.0 in the docker container, and generate .abi.0.8 and .abi.2.0 files and allow people to verify abi using either abigail 0.8 or 2.0. Or somehow figure out if we can generate universal abi files that are parsed correctly by both abigail 0.8 and 2.0.

@gmelikov
Copy link
Member

gmelikov commented Nov 3, 2021

Got it, we already have a minimum version check https://github.com/openzfs/zfs/blob/3eb3e4d14cf008045b79afbbe9d24812d56917be/Makefile.am#L133

Proposed plan:

@xnox
Copy link
Contributor Author

xnox commented Nov 3, 2021

Got it, we already have a minimum version check https://github.com/openzfs/zfs/blob/3eb3e4d14cf008045b79afbbe9d24812d56917be/Makefile.am#L133

Proposed plan:

Great! Let me prepare all that then!

Upgrade Dockerfile to the next Ubuntu LTS release, and thus to
libabigail 2.0 release, which uses new ABI files incompatible with
previously used 1.8x series.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
@xnox xnox marked this pull request as ready for review November 8, 2021 15:40
xnox added a commit to xnox/zfs that referenced this pull request Nov 8, 2021
This commit should be reverted once
openzfs/libabigail-docker#2 is merged and
deployed, and new :latest image is tagged.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
@xnox xnox mentioned this pull request Nov 8, 2021
13 tasks
@gmelikov gmelikov merged commit ee2393a into openzfs:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants