This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Add _ALIGNMENT_REQUIRED to isa_defs.h for checksums #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_ALIGNMENT_REQUIRED needs to be #defined in isa_defs.h in order to port the Illumos checksum code to ZoL: 4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R OpenZFS-issue: https://www.illumos.org/issues/4185 OpenZFS-commit: openzfs/openzfs@45818ee
|
This LGTM. Is this the only SPL side change needed for OpenZFS 4185? If so I don't have any objection to merging so the ZoL PR can be rebuilt against master. |
|
Yep, it's the only change I can see. I'm still trying to get 4185 to build on all platforms, but don't anticipate any further SPL changes. I'll remove the "Test build only. Do not pull" line so you can pull it if you want. |
|
Merged as: 5ad98ad Add _ALIGNMENT_REQUIRED to isa_defs.h for checksums |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ALIGNMENT_REQUIRED needs to be #defined in
isa_defs.hin order toport the Illumos checksum code to ZoL:
OpenZFS 4185 - add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R
OpenZFS-issue: https://www.illumos.org/issues/4185
OpenZFS-commit: openzfs/openzfs@45818ee