Skip to content

Commit

Permalink
Revert "Don't ashift-align vdev read requests."
Browse files Browse the repository at this point in the history
This reverts commit a5c20e2 which
accidentally introduced a regression for real 4k sector devices.
See issue #1065 for details.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #1065
  • Loading branch information
behlendorf committed Oct 24, 2012
1 parent f21e5c6 commit 178e73b
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions module/zfs/zio.c
Original file line number Diff line number Diff line change
Expand Up @@ -2438,25 +2438,19 @@ zio_vdev_io_start(zio_t *zio)

align = 1ULL << vd->vdev_top->vdev_ashift;

/*
* On Linux, we don't care about read alignment. The backing block
* device driver will take care of that for us.
* The only exception is raidz, which needs a full block for parity.
*/
if (P2PHASE(zio->io_size, align) != 0 &&
(zio->io_type != ZIO_TYPE_READ ||
vd->vdev_ops == &vdev_raidz_ops)) {
if (P2PHASE(zio->io_size, align) != 0) {
uint64_t asize = P2ROUNDUP(zio->io_size, align);
char *abuf = zio_buf_alloc(asize);
ASSERT(vd == vd->vdev_top);
if (zio->io_type == ZIO_TYPE_WRITE) {
bcopy(zio->io_data, abuf, zio->io_size);
bzero(abuf + zio->io_size, asize - zio->io_size);
}
zio_push_transform(zio, abuf, asize, asize, zio_subblock);
ASSERT(P2PHASE(zio->io_size, align) == 0);
}

ASSERT(P2PHASE(zio->io_offset, align) == 0);
ASSERT(P2PHASE(zio->io_size, align) == 0);
VERIFY(zio->io_type != ZIO_TYPE_WRITE || spa_writeable(spa));

/*
Expand Down

0 comments on commit 178e73b

Please sign in to comment.