-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Linux 6.12: f_version removed from struct file
linux/torvalds@11068e0b64cb removes it, suggesting this was a always there as a helper to handle concurrent seeks, which all filesystems now handle themselves if necessary. Without looking into the mechanism, I can imagine how it might have been used, but we have always set it to zero and never read from it, presumably because we've always tracked per-caller position through the znode anyway. So I don't see how there can be any functional change for us by removing it. I've stayed conservative though and left it in for older kernels, since its clearly not hurting anything there. Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <robn@despairlabs.com> Closes #16582
- Loading branch information
1 parent
df3b9d8
commit 1c7f2f6
Showing
3 changed files
with
35 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
dnl # | ||
dnl # 6.12 removed f_version from struct file | ||
dnl # | ||
AC_DEFUN([ZFS_AC_KERNEL_SRC_FILE_F_VERSION], [ | ||
ZFS_LINUX_TEST_SRC([file_f_version], [ | ||
#include <linux/fs.h> | ||
static const struct f __attribute__((unused)) = { | ||
.f_version = 0; | ||
}; | ||
]) | ||
]) | ||
|
||
AC_DEFUN([ZFS_AC_KERNEL_FILE_F_VERSION], [ | ||
AC_MSG_CHECKING([whether file->f_version exists]) | ||
ZFS_LINUX_TEST_RESULT([file_f_version], [ | ||
AC_MSG_RESULT(yes) | ||
AC_DEFINE(HAVE_FILE_F_VERSION, 1, | ||
[file->f_version exists]) | ||
], [ | ||
AC_MSG_RESULT(no) | ||
]) | ||
]) | ||
|
||
AC_DEFUN([ZFS_AC_KERNEL_FILE], [ | ||
ZFS_AC_KERNEL_FILE_F_VERSION | ||
]) | ||
|
||
AC_DEFUN([ZFS_AC_KERNEL_SRC_FILE], [ | ||
ZFS_AC_KERNEL_SRC_FILE_F_VERSION | ||
]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters