Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zpool add -n not working for spare #1106

Closed
ThomDietrich opened this issue Nov 23, 2012 · 9 comments
Closed

zpool add -n not working for spare #1106

ThomDietrich opened this issue Nov 23, 2012 · 9 comments
Milestone
0.7.0

Comments

@ThomDietrich
Copy link

A bug i saw with rc11:
'' zpool add -n tank spare ata-.....''
will show me the old configuration rather than the new one with the spare. The actual adding without "-n" works.
@behlendorf
Copy link
Contributor

Is this just for spare vdevs? Does it work correctly for primary pool, log, and cache vdevs?

@ThomDietrich
Copy link
Author

Hey,
i can only confirm that -n worked when I added another raidz to the existing volume. I do not use cache nor log devices.

@roedie
Copy link

roedie commented Oct 17, 2013

I can confirm that adding cache devices with 'zpool add -n' does not show the changes it will do to the pool. This is with 0.6.2.

@FransUrbo
Copy link
Contributor

With latest HEAD (pre-0.6.3), all but cache and spare works just fine.

@roedie
Copy link

roedie commented Jun 8, 2014

That's correct, but that what the bug report is all about. With -n you see all changes except for changes related to the cache and spares.

@FransUrbo
Copy link
Contributor

Yeah, I saw that. I just wanted confirm that the problem still occurs.

@roedie
Copy link

roedie commented Jun 8, 2014

On 08.06.2014 21:49, Turbo Fredriksson wrote:

Yeah, I saw that. I just wanted confirm that the problem still occurs.

Reply to this email directly or view it on GitHub [1].

Links:

[1] #1106 (comment)

Aw, sorry, misunderstood you.

@dweeezil
Copy link
Contributor

I've got a WIP patch in #1801 which adds support for spares and have been meaning to finish the work and add support for cache devices but haven't had the time. Ugh, I see I did this back in October (so the branch is not based on a very recent master). I'll see if I can get to this by the end of the weekend.

@behlendorf behlendorf removed this from the 0.6.6 milestone Oct 7, 2014
@behlendorf behlendorf added Bug - Minor and removed Bug labels Oct 7, 2014
behlendorf pushed a commit that referenced this issue Feb 11, 2015
@dweeezil @behlendorf
Enhancements to zpool dry run mode.
e02b533 
In dry run mode, zpool should display more of the proposed pool
configuration for "zpool add".  This commit adds support for displaying
cache devices.

Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #1106
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 12, 2015
@dweeezil @behlendorf
Enhancements to zpool dry run mode.
bb6fad2 
In dry run mode, zpool should display more of the proposed pool
configuration for "zpool add".  This commit adds support for displaying
cache devices.

Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#1106
DeHackEd pushed a commit to DeHackEd/zfs that referenced this issue Apr 4, 2015
@dweeezil @DeHackEd
Enhancements to zpool dry run mode.
e76bd41 
In dry run mode, zpool should display more of the proposed pool
configuration for "zpool add".  This commit adds support for displaying
cache devices.

Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#1106
DeHackEd pushed a commit to DeHackEd/zfs that referenced this issue Apr 5, 2015
@dweeezil @DeHackEd
Enhancements to zpool dry run mode.
45e40aa 
In dry run mode, zpool should display more of the proposed pool
configuration for "zpool add".  This commit adds support for displaying
cache devices.

Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#1106
@behlendorf behlendorf added this to the 0.7.0 milestone Mar 26, 2016
@behlendorf
Copy link
Contributor

Closing, addressed by e02b533

pcd1193182 pushed a commit to pcd1193182/zfs that referenced this issue Sep 26, 2023
@dependabot
Bump pin-project from 1.1.2 to 1.1.3 in /cmd/zfs_object_agent (openzf…
c731144 
…s#1106)

Bumps [pin-project](https://github.com/taiki-e/pin-project) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/taiki-e/pin-project/releases)
- [Changelog](https://github.com/taiki-e/pin-project/blob/main/CHANGELOG.md)
- [Commits](taiki-e/pin-project@v1.1.2...v1.1.3)

---
updated-dependencies:
- dependency-name: pin-project
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
5 participants
@behlendorf @FransUrbo @roedie @dweeezil @ThomDietrich