ZED_SYSLOG_SUBCLASS_EXCLUDE="history_event" breaks history_event-zfs-list-cacher.sh

[dmtrbm]

System information

Type	Version/Name
Distribution Name	Arch
Distribution Version	rolling
Linux Kernel	5.9.4-arch1-1
Architecture	x86_64
ZFS Version	2.0.0-rc5

Describe the problem you're observing

With this option set by default in /etc/zfs/zed.d/zed.rc, /etc/zfs/zfs-list.cache/* is no longer updated.

Describe how to reproduce the problem

zfs create rpool/test, /etc/zfs/zfs-list.cache/rpool is unchanged.

Include any warning/errors/backtraces from the system logs

Output of history_event-zfs-list-cacher.sh:

+ FSLIST_DIR=/etc/zfs/zfs-list.cache
+ FSLIST_TMP=/usr/var/run/zfs-list.cache.new
+ FSLIST=/etc/zfs/zfs-list.cache/rpool
+ '[' -w /etc/zfs/zfs-list.cache/rpool ']'
+ '[' -f /etc/zfs/zed.d/zed.rc ']'
+ . /etc/zfs/zed.d/zed.rc
++ ZED_USE_ENCLOSURE_LEDS=1
++ ZED_SYSLOG_SUBCLASS_EXCLUDE=history_event
+ . /etc/zfs/zed.d/zed-functions.sh
++ : /var/lock
++ : 3600
++ : 0
++ : /var/run
++ : daemon.notice
++ : zed
++ ZED_FLOCK_FD=8
+ zed_exit_if_ignoring_this_event
+ '[' -n '' ']'
+ '[' -n history_event ']'
+ eval 'case history_event in
history_event) exit 0;;
*);;
esac'
++ case history_event in
++ exit 0
+ exec

Commenting it out fixes cache updates:

+ FSLIST_DIR=/etc/zfs/zfs-list.cache
+ FSLIST_TMP=/usr/var/run/zfs-list.cache.new
+ FSLIST=/etc/zfs/zfs-list.cache/rpool
+ '[' -w /etc/zfs/zfs-list.cache/rpool ']'
+ '[' -f /etc/zfs/zed.d/zed.rc ']'
+ . /etc/zfs/zed.d/zed.rc
++ ZED_USE_ENCLOSURE_LEDS=1
+ . /etc/zfs/zed.d/zed-functions.sh
++ : /var/lock
++ : 3600
++ : 0
++ : /var/run
++ : daemon.notice
++ : zed
++ ZED_FLOCK_FD=8
+ zed_exit_if_ignoring_this_event
+ '[' -n '' ']'
+ '[' -n '' ']'
+ zed_check_cmd /usr/bin/zfs sort diff grep
+ local cmd
+ local rv=0
+ for cmd in "$@"
+ command -v /usr/bin/zfs
+ for cmd in "$@"
+ command -v sort
+ for cmd in "$@"
+ command -v diff
+ for cmd in "$@"
+ command -v grep
+ return 0
+ printf %s rpool/test
+ grep @
+ case "${ZEVENT_HISTORY_INTERNAL_NAME}" in
+ zed_lock zfs-list
+ local lockfile=zfs-list
+ local fd=8
+ local umask_bak
+ local err
+ '[' -n zfs-list ']'
+ expr zfs-list : '.*/'
+ lockfile=/var/lock/zfs-list
++ umask
+ umask_bak=0022
+ umask 077
+ eval 'exec 8> '\''/var/lock/zfs-list'\'''
++ exec
++ flock --exclusive 8
+ err=
+ '[' 0 -ne 0 ']'
+ umask 0022
+ trap abort_alter EXIT
+ PROPS=name,mountpoint,canmount,atime,relatime,devices,exec,readonly,setuid,nbmand,encroot,keylocation,org.openzfs.systemd:requires,org.openzfs.systemd:requires-mounts-for,org.openzfs.systemd:before,org.openzfs.systemd:after,org.openzfs.systemd:wanted-by,org.openzfs.systemd:required-by,org.openzfs.systemd:nofail,org.openzfs.systemd:ignore
+ /usr/bin/zfs list -H -t filesystem -o name,mountpoint,canmount,atime,relatime,devices,exec,readonly,setuid,nbmand,encroot,keylocation,org.openzfs.systemd:requires,org.openzfs.systemd:requires-mounts-for,org.openzfs.systemd:before,org.openzfs.systemd:after,org.openzfs.systemd:wanted-by,org.openzfs.systemd:required-by,org.openzfs.systemd:nofail,org.openzfs.systemd:ignore -r rpool
+ sort /usr/var/run/zfs-list.cache.new -o /usr/var/run/zfs-list.cache.new
+ diff -q /usr/var/run/zfs-list.cache.new /etc/zfs/zfs-list.cache/rpool
Files /usr/var/run/zfs-list.cache.new and /etc/zfs/zfs-list.cache/rpool differ
+ mv /usr/var/run/zfs-list.cache.new /etc/zfs/zfs-list.cache/rpool
+ rm -f /usr/var/run/zfs-list.cache.new
+ finished
+ zed_unlock zfs-list
+ local lockfile=zfs-list
+ local fd=8
+ local err
+ '[' -n zfs-list ']'
+ expr zfs-list : '.*/'
+ lockfile=/var/lock/zfs-list
++ flock --unlock 8
+ err=
+ '[' 0 -ne 0 ']'
+ eval 'exec 8>&-'
++ exec
+ trap - EXIT
+ exit 0