Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zhack is flaky on FreeBSD #11854

Closed
ghost opened this issue Apr 7, 2021 · 1 comment
Closed

zhack is flaky on FreeBSD #11854

ghost opened this issue Apr 7, 2021 · 1 comment
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Component: Userspace user space functionality Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@ghost
Copy link

ghost commented Apr 7, 2021

Describe the problem you're observing

zhack occasionally segfaults on FreeBSD, causing some tests to fail randomly. When I looked at the core in a debugger, the fault was literally in rand(), but it really doesn't make sense to me. I suspect somewhere else is corrupting the stack.

Describe how to reproduce the problem

Run a test that uses zhack, such as cli_root/zpool_import/zpool_import_features_001_pos, on FreeBSD until it fails.

Include any warning/errors/backtraces from the system logs
@ghost ghost added Type: Defect Incorrect behavior (e.g. crash, hang) Component: Userspace user space functionality labels Apr 7, 2021
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this issue Apr 7, 2021
ZTS: Tests using zhack may fail on FreeBSD
37f6dfd 
Issue openzfs#11854

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost mentioned this issue Apr 7, 2021
Merged
13 tasks
@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Apr 7, 2021
behlendorf pushed a commit that referenced this issue Apr 8, 2021
ZTS: Tests using zhack may fail on FreeBSD
3834015 
As described in #11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue #11854
Closes #11855
mcmilk pushed a commit to mcmilk/zfs that referenced this issue Apr 10, 2021
@mcmilk
ZTS: Tests using zhack may fail on FreeBSD
f7ce00b 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
adamdmoss pushed a commit to adamdmoss/zfs that referenced this issue Apr 10, 2021
@adamdmoss
ZTS: Tests using zhack may fail on FreeBSD
9221923 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
mcmilk pushed a commit to mcmilk/zfs that referenced this issue Apr 10, 2021
@mcmilk
ZTS: Tests using zhack may fail on FreeBSD
89c42bb 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Apr 14, 2021
@behlendorf
ZTS: Tests using zhack may fail on FreeBSD
72a9750 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this issue May 6, 2021
ZTS: Tests using zhack may fail on FreeBSD
03ce679 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this issue May 6, 2021
ZTS: Tests using zhack may fail on FreeBSD
0cee9b1 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this issue May 6, 2021
ZTS: Tests using zhack may fail on FreeBSD
5741a66 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this issue May 7, 2021
ZTS: Tests using zhack may fail on FreeBSD
c80217a 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this issue May 10, 2021
ZTS: Tests using zhack may fail on FreeBSD
6004d3c 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this issue May 10, 2021
ZTS: Tests using zhack may fail on FreeBSD
96da574 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this issue May 10, 2021
ZTS: Tests using zhack may fail on FreeBSD
b37f512 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
ghost pushed a commit to truenas/zfs that referenced this issue May 13, 2021
ZTS: Tests using zhack may fail on FreeBSD
e6b394f 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
behlendorf pushed a commit that referenced this issue May 20, 2021
@behlendorf
ZTS: Tests using zhack may fail on FreeBSD
dea9aed 
As described in #11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue #11854
Closes #11855
sempervictus pushed a commit to sempervictus/zfs that referenced this issue May 31, 2021
ZTS: Tests using zhack may fail on FreeBSD
8922c35 
As described in openzfs#11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue openzfs#11854
Closes openzfs#11855
tonyhutter pushed a commit that referenced this issue Jun 23, 2021
@tonyhutter
ZTS: Tests using zhack may fail on FreeBSD
57490d5 
As described in #11854, zhack is occasionally segfaulting on FreeBSD. 
Debugging this is proving to be tricky. To avoid false positives in
the CI add entries for the tests that use zhack in zts-report to 
accept that they may occasionally fail on FreeBSD.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Issue #11854
Closes #11855
@ghost
Copy link
Author

ghost commented Aug 31, 2021 •
edited by ghost
Loading

Fixed in FreeBSD.
main: https://cgit.freebsd.org/src/commit/?id=3a57f08b5042f15bb8ffb2fcce99d082d225d4cf
stable/13: https://cgit.freebsd.org/src/commit/?h=stable/13&id=09d4fe40e039d4b08a034454c36aed86571725b0

@ghost ghost closed this as completed Aug 31, 2021
ghost pushed a commit to truenas/zfs that referenced this issue Aug 31, 2021
ZTS: Remove exceptions for flaky zhack on FreeBSD
1799a6a 
Issue openzfs#11854 has been resolved, so we can remove the exceptions for it.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost mentioned this issue Aug 31, 2021
Merged
13 tasks
behlendorf pushed a commit that referenced this issue Sep 1, 2021
ZTS: Remove exceptions for flaky zhack on FreeBSD
c27c124 
Issue #11854 has been resolved, so we can remove the exceptions for it.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #12527
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Sep 15, 2021
@tonyhutter
ZTS: Remove exceptions for flaky zhack on FreeBSD
aef8a72 
Issue openzfs#11854 has been resolved, so we can remove the exceptions for it.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#12527
rincebrain pushed a commit to rincebrain/zfs that referenced this issue Sep 22, 2021
@rincebrain
ZTS: Remove exceptions for flaky zhack on FreeBSD
e8a2e04 
Issue openzfs#11854 has been resolved, so we can remove the exceptions for it.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#12527
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Component: Userspace user space functionality Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behlendorf