Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zed: Use PCI slot fault LEDs for NVMe #12648

Closed
tonyhutter opened this issue Oct 15, 2021 · 0 comments
Closed

zed: Use PCI slot fault LEDs for NVMe #12648

tonyhutter opened this issue Oct 15, 2021 · 0 comments
Assignees
@tonyhutter
Labels
Type: Feature Feature request or new feature

Comments

@tonyhutter
Copy link
Contributor

Describe the feature would like to see added to OpenZFS

Update zed to turn on the fault LED at /sys/bus/pci/slots/<slot>/attention for NVMe devices. zed can currently only turn on the fault LEDs for JBODs (in /sys/class/enclosure).

How will this feature improve OpenZFS?

Extend the zed LED fault handling to PCI NVMe devices.

Additional context

To map an NVMe device to it's slot:

# Lookup the devices PCI address
$ cat /sys/class/block/nvme1n1/device/address 
0000:61:00.0

# Iterate though /sys/bus/pci/slots/* until you find a matching address
[root@garter1:~]# cat /sys/bus/pci/slots/1/address 
0000:60:00
[root@garter1:~]# cat /sys/bus/pci/slots/2/address 
0000:61:00                                     <---  match!
@tonyhutter tonyhutter added the Type: Feature Feature request or new feature label Oct 15, 2021
@tonyhutter tonyhutter self-assigned this Oct 15, 2021
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Oct 26, 2021
@tonyhutter
zed: Control NVMe fault LEDs
f9584f6 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Closes: openzfs#12648

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Oct 26, 2021
@tonyhutter
zed: Control NVMe fault LEDs
be126a1 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Closes: openzfs#12648

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
@tonyhutter tonyhutter mentioned this issue Oct 26, 2021
Merged
13 tasks
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 3, 2021
@tonyhutter
zed: Control NVMe fault LEDs
cfd9e99 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Closes: openzfs#12648

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 4, 2021
@tonyhutter
zed: Control NVMe fault LEDs
3c678ae 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Closes: openzfs#12648

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 10, 2021
@tonyhutter
zed: Control NVMe fault LEDs
1fca958 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#12648
Closes openzfs#12695
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 10, 2021
@tonyhutter
zed: Control NVMe fault LEDs
a33623f 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#12648
Closes openzfs#12695
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 13, 2021
@tonyhutter
zed: Control NVMe fault LEDs
4afd3b4 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#12648
Closes openzfs#12695
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 13, 2021
@tonyhutter
zed: Control NVMe fault LEDs
4ba1a62 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#12648
Closes openzfs#12695
ofaaland pushed a commit to LLNL/zfs that referenced this issue Mar 9, 2023
@tonyhutter @ofaaland
zed: Control NVMe fault LEDs
54484cd 
The ZED code currently can only turn on the fault LED for
a faulted disk in a JBOD enclosure.  This extends support
for faulted NVMe disks as well.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#12648
Closes openzfs#12695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyhutter tonyhutter

Labels
Type: Feature Feature request or new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tonyhutter