Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arcstat -p and fix for compatibility with py2/3 #12916

Closed
justinpryzby opened this issue Dec 27, 2021 · 1 comment · Fixed by #13767
Closed

arcstat -p and fix for compatibility with py2/3 #12916

justinpryzby opened this issue Dec 27, 2021 · 1 comment · Fixed by #13767
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@justinpryzby
Copy link

System information

Type Version/Name
Distribution Name CentOS Linux
Distribution Version 7
Kernel Version 3.10.0-1160.11.1.el7
Architecture x86_64
OpenZFS Version 2.0.6 and .7

Describe the problem you're observing

arcstat -p doesn't work with either version of python:

Describe how to reproduce the problem

$ /usr/bin/python3.6 /usr/bin/arcstat -p
time read miss miss% dmis dm% pmis pm% mmis mm% size c avail
Traceback (most recent call last):
File "/usr/bin/arcstat", line 521, in
main()
File "/usr/bin/arcstat", line 506, in main
print_values()
File "/usr/bin/arcstat", line 260, in print_values
sys.stdout.write(sep.join(fmt(col) for col in hdr))
TypeError: sequence item 1: expected str instance, float found

Also, arcstat without -p shows rounded values with only one significant figure when run with py2.7.
The rounding behavior changed in py3 (/ means FP division, and integer division is now //).
@justinpryzby justinpryzby added the Type: Defect Incorrect behavior (e.g. crash, hang) label Dec 27, 2021
@justinpryzby
Copy link
Author

justinpryzby commented Dec 27, 2021 •
edited
Loading 

-        num = num / scale
+        num = float(num) / scale
...
-        fmt = lambda col: v[col]
+        fmt = lambda col: str(v[col])

@r-ricci r-ricci mentioned this issue Aug 11, 2022
Merged
13 tasks
behlendorf pushed a commit that referenced this issue Aug 12, 2022
@r-ricci
arcstat: fix -p option
e713b69 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes #12916 
Closes #13767
behlendorf pushed a commit that referenced this issue Aug 12, 2022
@r-ricci @behlendorf
arcstat: fix -p option
533779f 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes #12916 
Closes #13767
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@r-ricci @nicman23
arcstat: fix -p option
81de0c2 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@r-ricci @nicman23
arcstat: fix -p option
d49b83e 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Sep 13, 2022
@r-ricci @lundman
arcstat: fix -p option
a54b644 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
beren12 pushed a commit to beren12/zfs that referenced this issue Sep 19, 2022
@r-ricci @beren12
arcstat: fix -p option
69fa56d 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
548561c 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
89e3be2 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
767c397 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
ad5c52e 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
441c087 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
6149c98 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
d5e10a0 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
9a47748 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
83b82a3 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
efe4a9c 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
cf954f3 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
02d1c12 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
811fbe2 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
ae958f1 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
8df054f 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
751e31d 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
969e598 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
ace6ef5 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
61a92e7 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
3497431 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
14c6218 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
e58f769 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
5e9f838 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
b55b0d2 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
236204f 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
bbc2e28 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
bfa22af 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
f813fe3 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
2d4ea2e 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
19d61d5 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
4287e96 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
0196690 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
fa1deda 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Sep 23, 2022
@r-ricci @andrewc12
arcstat: fix -p option
f08a97e 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
snajpa pushed a commit to vpsfreecz/zfs that referenced this issue Oct 22, 2022
@r-ricci @snajpa
arcstat: fix -p option
b162f78 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
snajpa pushed a commit to vpsfreecz/zfs that referenced this issue Oct 22, 2022
@r-ricci @snajpa
arcstat: fix -p option
1dc8375 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
snajpa pushed a commit to vpsfreecz/zfs that referenced this issue Oct 23, 2022
@r-ricci @snajpa
arcstat: fix -p option
299691e 
When the -p option is used, a list of floats is passed to sep.join(),
which expects strings. Fix this by converting each value to a string.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Roberto Ricci <ricci@disroot.org>
Closes openzfs#12916 
Closes openzfs#13767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

arcstat: fix -p option
1 participant
@justinpryzby