Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux Kernel 6.2 renamed get_acl to get_inode_acl #14323

Closed
fantix opened this issue Dec 24, 2022 · 0 comments
Closed

Linux Kernel 6.2 renamed get_acl to get_inode_acl #14323

fantix opened this issue Dec 24, 2022 · 0 comments
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@fantix
Copy link

fantix commented Dec 24, 2022

System information

Type Version/Name
Distribution Name Gentoo
Distribution Version -
Kernel Version next-20221220
Architecture LoongArch
OpenZFS Version 2.1.99-1641_gc935fe2e9

Describe the problem you're observing

checking whether iops->get_acl() exists... configure: error:
	*** None of the expected "iops->get_acl()" interfaces were detected.
	*** This may be because your kernel version is newer than what is
	*** supported, or you are using a patched custom kernel with
	*** incompatible modifications.
	***
	*** ZFS Version: zfs-2.1.99-1641_gc935fe2e9
	*** Compatible Kernels: 3.10 - 6.0

⚠️ ⚠️ Kernel renamed get_acl to get_inode_acl: torvalds/linux@cac2f8b ⚠️ ⚠️

Describe how to reproduce the problem

Build oepnzfs master with a post-6.1 kernel.

Include any warning/errors/backtraces from the system logs

# make modules -C /usr/src/linux  M=/var/tmp/portage/sys-fs/zfs-loong-kmod-9999/work/zfs-loong-kmod-9999/build/inode_operations_get_acl_rcu
make: Entering directory '/usr/src/linux-loongson'
  CC [M]  /var/tmp/portage/sys-fs/zfs-loong-kmod-9999/work/zfs-loong-kmod-9999/build/inode_operations_get_acl_rcu/inode_operations_get_acl_rcu.o
/var/tmp/portage/sys-fs/zfs-loong-kmod-9999/work/zfs-loong-kmod-9999/build/inode_operations_get_acl_rcu/inode_operations_get_acl_rcu.c:53:36: error: initialization of ‘struct posix_acl * (*)(struct user_namespace *, struct dentry *, int)’ from incompatible pointer type ‘struct posix_acl * (*)(struct inode *, int,  bool)’ {aka ‘struct posix_acl * (*)(struct inode *, int,  _Bool)’} [-Werror=incompatible-pointer-types]
   53 |                         .get_acl = get_acl_fn,
      |                                    ^~~~~~~~~~
/var/tmp/portage/sys-fs/zfs-loong-kmod-9999/work/zfs-loong-kmod-9999/build/inode_operations_get_acl_rcu/inode_operations_get_acl_rcu.c:53:36: note: (near initialization for ‘iops.get_acl’)
cc1: all warnings being treated as errors
make[1]: *** [scripts/Makefile.build:250: /var/tmp/portage/sys-fs/zfs-loong-kmod-9999/work/zfs-loong-kmod-9999/build/inode_operations_get_acl_rcu/inode_operations_get_acl_rcu.o] Error 1
make: *** [Makefile:1994: /var/tmp/portage/sys-fs/zfs-loong-kmod-9999/work/zfs-loong-kmod-9999/build/inode_operations_get_acl_rcu] Error 2
@fantix fantix added the Type: Defect Incorrect behavior (e.g. crash, hang) label Dec 24, 2022
ckane added a commit to ckane/zfs that referenced this issue Dec 27, 2022
@ckane
[linux 6.2 compat] get_acl() got moved to get_inode_acl() in 6.2
4a73b72 
Linux 6.2 renamed the get_acl() operation to get_inode_acl() in
the inode_operations struct. This should fix Issue openzfs#14323.

Signed-off-by: Coleman Kane <ckane@colemankane.org>
@ckane ckane mentioned this issue Dec 27, 2022
Closed
13 tasks
ckane added a commit to ckane/zfs that referenced this issue Dec 27, 2022
@ckane
[linux 6.2 compat] get_acl() got moved to get_inode_acl() in 6.2
e870465 
Linux 6.2 renamed the get_acl() operation to get_inode_acl() in
the inode_operations struct. This should fix Issue openzfs#14323.

Signed-off-by: Coleman Kane <ckane@colemankane.org>
ckane added a commit to ckane/zfs that referenced this issue Jan 6, 2023
@ckane
[linux 6.2 compat] get_acl() got moved to get_inode_acl() in 6.2
ce85d2c 
Linux 6.2 renamed the get_acl() operation to get_inode_acl() in
the inode_operations struct. This should fix Issue openzfs#14323.

Signed-off-by: Coleman Kane <ckane@colemankane.org>
ryao pushed a commit to ryao/zfs that referenced this issue Jan 9, 2023
@ckane @ryao
linux 6.2 compat: get_acl() got moved to get_inode_acl() in 6.2
6a3ebce 
Linux 6.2 renamed the get_acl() operation to get_inode_acl() in
the inode_operations struct. This should fix Issue openzfs#14323.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#14323
Closes openzfs#14331
ryao pushed a commit to ryao/zfs that referenced this issue Jan 10, 2023
@ckane @ryao
linux 6.2 compat: get_acl() got moved to get_inode_acl() in 6.2
524c742 
Linux 6.2 renamed the get_acl() operation to get_inode_acl() in
the inode_operations struct. This should fix Issue openzfs#14323.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#14323
Closes openzfs#14331
behlendorf pushed a commit that referenced this issue Jan 10, 2023
@ckane @behlendorf
linux 6.2 compat: get_acl() got moved to get_inode_acl() in 6.2
b586ea5 
Linux 6.2 renamed the get_acl() operation to get_inode_acl() in
the inode_operations struct. This should fix Issue #14323.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes #14323
Closes #14331
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Mar 3, 2023
@ckane @lundman
linux 6.2 compat: get_acl() got moved to get_inode_acl() in 6.2
3257519 
Linux 6.2 renamed the get_acl() operation to get_inode_acl() in
the inode_operations struct. This should fix Issue openzfs#14323.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#14323
Closes openzfs#14331
Wenri pushed a commit to Wenri/zfs that referenced this issue Sep 13, 2023
@ckane @Wenri
linux 6.2 compat: get_acl() got moved to get_inode_acl() in 6.2
e8b6bbb 
Linux 6.2 renamed the get_acl() operation to get_inode_acl() in
the inode_operations struct. This should fix Issue openzfs#14323.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes openzfs#14323
Closes openzfs#14331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[linux 6.2 compat] get_acl() got moved to get_inode_acl(), bio_set_op_attrs removed in 6.2 ckane/zfs
1 participant
@fantix