Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deb-utils fails when there is a whitespace in the existing $PATH environment variable #14338

Closed
martin-rueegg opened this issue Dec 29, 2022 · 0 comments
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@martin-rueegg
Copy link
Contributor

System information

Type Version/Name
Distribution Name Ubuntu
Distribution Version 20.04.5 LTS (focal)
Kernel Version 5.10.16.3-microsoft-standard-WSL2+
Architecture x86
OpenZFS Version zfs-2.1.0-rc4, zfs-kmod-2.1.0-rc4

Describe the problem you're observing

When trying to build the deb tools with make -j1 deb-utils the build fails with the following error: env: ‘Files’: No such file or directory

Describe how to reproduce the problem

WSL_KERNEL_SOURCE_DIR=../kernel
sh autogen.sh
./configure --prefix=/ --libdir=/lib --includedir=/usr/include --datarootdir=/usr/share --enable-linux-builtin=yes \
 --with-linux=$WSL_KERNEL_SOURCE_DIR --with-linux-obj=$WSL_KERNEL_SOURCE_DIR --enable-systemd
./copy-builtin $WSL_KERNEL_SOURCE_DIR
make -j8
make -j1 deb-utils

Include any warning/errors/backtraces from the system logs

name=zfs; \
version=2.1.0-rc4; \
arch=`rpm -qp ${name}-${version}.src.rpm --qf %{arch} | tail -1`; \
debarch=`dpkg --print-architecture`; \
pkg1=${name}-${version}.${arch}.rpm; \
pkg2=libnvpair3-${version}.${arch}.rpm; \
pkg3=libuutil3-${version}.${arch}.rpm; \
pkg4=libzfs5-${version}.${arch}.rpm; \
pkg5=libzpool5-${version}.${arch}.rpm; \
pkg6=libzfs5-devel-${version}.${arch}.rpm; \
pkg7=${name}-test-${version}.${arch}.rpm; \
pkg8=${name}-dracut-${version}.noarch.rpm; \
pkg9=${name}-initramfs-${version}.${arch}.rpm; \
pkg10=`ls python*-pyzfs-${version}* | tail -1`; \
path_prepend=`mktemp -d /tmp/intercept.XXXXXX`; \
echo "#!/bin/bash" > ${path_prepend}/dh_shlibdeps; \
echo "`which dh_shlibdeps` -- \
 -xlibuutil3linux -xlibnvpair3linux -xlibzfs5linux -xlibzpool5linux" \
 >> ${path_prepend}/dh_shlibdeps; \
chmod +x ${path_prepend}/dh_shlibdeps; \
env PATH=${path_prepend}:${PATH} \
fakeroot alien --bump=0 --scripts --to-deb --target=$debarch \
    $pkg1 $pkg2 $pkg3 $pkg4 $pkg5 $pkg6 $pkg7 \
    $pkg8 $pkg9 $pkg10 || exit 1; \
rm -f ${path_prepend}/dh_shlibdeps; \
rmdir ${path_prepend}; \
rm -f $pkg1 $pkg2 $pkg3 $pkg4 $pkg5 $pkg6 $pkg7 \
    $pkg8 $pkg9 $pkg10;
env: ‘Files’: No such file or directory
make: *** [Makefile:1726: deb-utils] Error 1
@martin-rueegg martin-rueegg added the Type: Defect Incorrect behavior (e.g. crash, hang) label Dec 29, 2022
martin-rueegg added a commit to metaworx/zfs that referenced this issue Dec 29, 2022
@martin-rueegg martin-rueegg mentioned this issue Dec 29, 2022
13 tasks
martin-rueegg added a commit to metaworx/zfs that referenced this issue Dec 29, 2022
Fix openzfs#14338, failing to build deb-utils if existing `$PATH` variable
would include a whitespace.

Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 13, 2023
Fix openzfs#14338, failing to build deb-utils if existing `$PATH` variable
would include a whitespace.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
Closes openzfs#14339
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 18, 2023
Fix openzfs#14338, failing to build deb-utils if existing `$PATH` variable
would include a whitespace.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
Closes openzfs#14339
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 19, 2023
Fix openzfs#14338, failing to build deb-utils if existing `$PATH` variable
would include a whitespace.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
Closes openzfs#14339
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Mar 3, 2023
Fix openzfs#14338, failing to build deb-utils if existing `$PATH` variable
would include a whitespace.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
Closes openzfs#14339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Development

No branches or pull requests

1 participant