Pool imported as sdX instead of /dev/disk/by-id #3043

azeemism · 2015-01-27T21:04:45Z

Hi,

Exporting then importing a pool shows devices listed as sdX under zpool status.

Pool was created as
zpool create spool mirror /dev/disk/by-id/... /dev/disk/by-id/...

Unless the -d options is used each time the pool is imported.
zpool import -d /dev/disk/by-id spool

This is not the case with v0.6.3-766_gfde0d6d.

Not sure if this is somehow related to,
#2482

Using:
VirtualBox
(fresh install) Debian Jessie
(dailies) zfs v0.6.3-22~~2d9d57~~jessie

Thanks,

Azeem

azeemism · 2015-01-29T18:39:28Z

I can now report that after the dailies fix,

zfsonlinux/pkg-zfs#138

If a pool is export it is imported back automatically with /dev/disk/by-id after a reboot (tested in VirtualBox). This wasn't the case before the fix.

However if the pool is imported manually, unless the "-d /dev/disk/by-id" option is used it gets imported as /dev/sdX.

It would be nice if "zpool import tank" remembered the disk naming format from either,

zpool create tank mirror /dev/disk/by-id /dev/disk/by-id

Or a previous import,

zpool import -d /dev/disk/by-id tank

But that is a minor concern.

FransUrbo · 2015-01-29T20:10:55Z

However if the pool is imported manually, unless the "-d /dev/disk/by-id" option is used it gets imported as /dev/sdX.

This is most likely due to the zpool.cache file. Try setting 'cachefile=none' on your pool(s) and, if it's still there, remove /etc/zfs/zpool.cache and recreate the initrd.

Also, make sure that USE_DISK_BY_ID='yes' in /etc/default/zfs (before recreating the initrd).=

azeemism · 2015-01-29T20:28:39Z

Okay will try this out right now.

I assume the command to recreate the initrd is,

mv initrd.img-3.16.0-4-amd64 initrd.img-3.16.0-4-amd64.old
update-initramfs -c -k all

azeemism · 2015-01-29T21:19:33Z

No change. An exported pool is always imported back as /dev/disk/by-id after reboot.'zpool import spool' is always imported as /dev/sdX

I am assuming it is better to have 'cachefile=none' specified as the default look to be '-', so I guess I should specify this setting moving on for all pool creation.

nano /etc/default/zfs
USE_DISK_BY_ID='yes'
Is the default setting which is good.

zpool set cachefile=none spool
Automatically deleted /etc/zfs/zpool.cache
At reboot zpool.cache was recreated

update-initramfs -c -k all

nicko88 · 2015-02-02T16:46:51Z

I think you might be running into this:
http://www.reddit.com/r/zfs/comments/2ugerx/workaround_to_restore_bypath_behavior_for_sata/

Bronek · 2015-11-15T18:53:20Z

I was experiencing identical issue until I removed zpool import -aN from initramfs ZFS hook of my system. After removing this command, my pools (except for root filesystem) are imported using zpool import -c /etc/zfs/zpool.cache -aN only. Since then the device names in my pools are no longer replaced with /dev/sdX . I raised an issue in ZFS package for my Linux distribution to remove zpool import -aN : archzfs/archzfs#50 .

It is possible that this issue might also be caused by iniramfs script importing indiscriminately all pools at boot time, rather than using zpool.cache

alexanderhaensch · 2016-01-20T11:21:43Z

I ran into this problem recently.
Wouldn't it be best to default the command
zpool import $pool
to
zpool import -d /dev/by-id $pool

The legacy /dev/sdX is getting more and more unreliable.

behlendorf · 2016-01-21T19:11:42Z

@alexanderhaensch you can change the default search order with the ZPOOL_IMPORT_PATH environment variable. See zpool.8.

       ZPOOL_IMPORT_PATH
              The  search path for devices or files to use with the pool. This
              is a colon-separated list of directories in  which  zpool  looks
              for  device  nodes and files.  Similar to the -d option in zpool
              import.

That said, you may be right and it's time to change the default. The primary reason it was left as /dev/ for so long was many of the distributions hasn't yet standardized on the /dev/disk/by-id/ convention. However, times are a changing and I can't think of a disro offland that doesn't ship with those udev rules.

It would be great if you set ZPOOL_IMPORT_PATH on your systems to simulate a change in the default search paths.

alexanderhaensch · 2016-01-28T16:26:42Z

@behlendorf setting the environment variable works great. Now i can import my pool much easier without having the sdX which is changing every boot. :)

behlendorf · 2016-01-28T21:52:52Z

@alexanderhaensch what did you end up setting it to. The default search order is as follows starting with by-vdev.

char *
zpool_default_import_path[DEFAULT_IMPORT_PATH_SIZE] = {
        "/dev/disk/by-vdev",    /* Custom rules, use first if they exist */
        "/dev/mapper",          /* Use multipath devices before components */
        "/dev/disk/by-uuid",    /* Single unique entry and persistent */
        "/dev/disk/by-id",      /* May be multiple entries and persistent */
        "/dev/disk/by-path",    /* Encodes physical location and persistent */
        "/dev/disk/by-label",   /* Custom persistent labels */
        "/dev"                  /* UNSAFE device names will change */
};

alexanderhaensch · 2016-01-30T08:22:22Z

For some reason, the function zfs_resolve_shortname does not use vdev to label. On my system always /dev is used.

alexanderhaensch · 2016-01-30T08:57:37Z

I tested a little bit:
with ZPOOL_IMPORT_PATH="/dev/disk/by-id" :

config:

        NAME                                               STATE     READ WRITE CKSUM
        storage                                            ONLINE       0     0     0
          raidz1-0                                         ONLINE       0     0     0
            ata-ST3000VX000-1CU166_W1F4HC6Q                ONLINE       0     0     0
            ata-ST3000VX000-1CU166_W1F45XDY                ONLINE       0     0     0
            ata-ST3000VX000-1CU166_W1F45WV8                ONLINE       0     0     0

cache
          ata-Corsair_Force_GT_113882030000070000A4-part3  ONLINE       0     0     0

with ZPOOL_IMPORT_PATH="/dev/disk/by-vdev" :

config:                                                                             
        NAME                                               STATE     READ WRITE CKSUM
        storage                                            ONLINE       0     0     0
          raidz1-0                                         ONLINE       0     0     0
            disk3                                          ONLINE       0     0     0
            disk2                                          ONLINE       0     0     0
            disk1                                          ONLINE       0     0     0
        cache
          ata-Corsair_Force_GT_113882030000070000A4-part3  ONLINE       0     0     0

without any ZPOOL_IMPORT_PATH :

config:
        NAME                                               STATE     READ WRITE CKSUM
        storage                                            ONLINE       0     0     0
          raidz1-0                                         ONLINE       0     0     0
            sdd                                            ONLINE       0     0     0
            sdf                                            ONLINE       0     0     0
            sda                                            ONLINE       0     0     0
        cache
          ata-Corsair_Force_GT_113882030000070000A4-part3  ONLINE       0     0     0

interestingly, the cache is always detected correct with the by-id name. It is the first matching entry. sda,sdd,sdf never match.

rlaager · 2016-04-18T18:38:12Z

This came up in the Ubuntu bug tracker as well: https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1571241

samvde · 2016-04-19T09:32:21Z

Additional info (I logged the Ubuntu bug report): I was not able to get the ZPOOL_IMPORT_PATH working for the root filesystem on Ubuntu 16.04, i.e. adding it to /etc/default/zfs does not propagate this into the initrd.

rlaager · 2016-04-19T16:00:45Z

Is zpool import ignoring zpool_default_import_path because of libblkid?

https://github.com/zfsonlinux/zfs/blob/8fc5674c522e22f0b97e4714bf5410e24d481afa/lib/libzfs/libzfs_import.c#L1599

When importing a pool using the blkid cache only the device node path was added to the list of known paths for a device. This results in 'zpool import' always using the sdX names in preference to the 'path' name stored in the label. To fix the issue the blkid import path has been updated to add both the 'path', 'devid', and 'devname' names from the label to known paths. Sanity check is done to ensure these paths do refer to the same device identified by blkid. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#3043

behlendorf · 2016-04-20T23:40:31Z

@rlaager spot on, I've added a patch to the existing #4523 pull request to address this. At its core the patch adds any alternate paths to the device which are described by the vdev label. This will preserve the original name if the device still is accessible by that path.

rlaager · 2016-04-21T01:02:22Z

@behlendorf I tested that patch. Applying only that patch fixes the issue observed in Ubuntu. That is, if I have a pool which was last imported using /dev/disk/by-id names, the patch causes zpool import to import it using /dev/disk/by-id names.

When importing a pool using the blkid cache only the device node path was added to the list of known paths for a device. This results in 'zpool import' always using the sdX names in preference to the 'path' name stored in the label. To fix the issue the blkid import path has been updated to add both the 'path', 'devid', and 'devname' names from the label to known paths. Sanity check is done to ensure these paths do refer to the same device identified by blkid. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#3043

When importing a pool using the blkid cache only the device node path was added to the list of known paths for a device. This results in 'zpool import' always using the sdX names in preference to the 'path' name stored in the label. To fix the issue the blkid import path has been updated to add both the 'path', 'devid', and 'devname' names from the label to the known paths. A sanity check is done to ensure these paths do refer to the same device identified by blkid. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#4523 Closes openzfs#3043

azeemism mentioned this issue Jan 28, 2015

Cannot install native zfs root file system with zfs dailies 0.6.3-22~2d9d57~jessie on Debian Jessie #3047

Closed

behlendorf added Bug - Minor labels Feb 6, 2015

behlendorf mentioned this issue Apr 20, 2016

Improved libblkid/libudev integration #4523

Closed

behlendorf closed this as completed in 325414e Apr 25, 2016

behlendorf added this to the 0.6.5.7 milestone Apr 25, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pool imported as sdX instead of /dev/disk/by-id #3043

Pool imported as sdX instead of /dev/disk/by-id #3043

azeemism commented Jan 27, 2015

azeemism commented Jan 29, 2015

FransUrbo commented Jan 29, 2015

azeemism commented Jan 29, 2015

azeemism commented Jan 29, 2015

nicko88 commented Feb 2, 2015

Bronek commented Nov 15, 2015

alexanderhaensch commented Jan 20, 2016

behlendorf commented Jan 21, 2016

alexanderhaensch commented Jan 28, 2016

behlendorf commented Jan 28, 2016

alexanderhaensch commented Jan 30, 2016

alexanderhaensch commented Jan 30, 2016

rlaager commented Apr 18, 2016

samvde commented Apr 19, 2016

rlaager commented Apr 19, 2016

behlendorf commented Apr 20, 2016

rlaager commented Apr 21, 2016

Pool imported as sdX instead of /dev/disk/by-id #3043

Pool imported as sdX instead of /dev/disk/by-id #3043

Comments

azeemism commented Jan 27, 2015

azeemism commented Jan 29, 2015

FransUrbo commented Jan 29, 2015

azeemism commented Jan 29, 2015

azeemism commented Jan 29, 2015

nicko88 commented Feb 2, 2015

Bronek commented Nov 15, 2015

alexanderhaensch commented Jan 20, 2016

behlendorf commented Jan 21, 2016

alexanderhaensch commented Jan 28, 2016

behlendorf commented Jan 28, 2016

alexanderhaensch commented Jan 30, 2016

alexanderhaensch commented Jan 30, 2016

rlaager commented Apr 18, 2016

samvde commented Apr 19, 2016

rlaager commented Apr 19, 2016

behlendorf commented Apr 20, 2016

rlaager commented Apr 21, 2016