Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZFS 0.6.5.7~1 on Ubuntu 14.04.5 with NFSv4 has broken ACL support #5371

Closed
gdevenyi opened this issue Nov 7, 2016 · 4 comments
Closed

ZFS 0.6.5.7~1 on Ubuntu 14.04.5 with NFSv4 has broken ACL support #5371

gdevenyi opened this issue Nov 7, 2016 · 4 comments

Comments

@gdevenyi
Copy link
Contributor

gdevenyi commented Nov 7, 2016

I host a "quarantine" on an ZFS storage server which consists a bunch of installed software shared across a number of desktop machines. I recently went to install some python3 based tools in the quarantine and ran into the following:

From an strace of running a python3 setuptools script on the quarantine drive, mounted on a client via NFSv4:

chmod("/opt/quarantine/pydpiper/2.0/build/lib/python3.4/site-packages/pydpiper-2.0-py3.4.egg", 0644) = 0
listxattr("dist/pydpiper-2.0-py3.4.egg", "system.nfs4_acl\0", 256) = 16
getxattr("dist/pydpiper-2.0-py3.4.egg", "system.nfs4_acl", "\x00\x00\x00\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x16\x01\x87\x00\x00\x00\x06OWNER@\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x12\x00\x81\x00\x00\x00\x06GROUP@\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x12\x00\x81\x00\x00\x00\x09EVERYONE@\x00\x00", 128) = 80
setxattr("/opt/quarantine/pydpiper/2.0/build/lib/python3.4/site-packages/pydpiper-2.0-py3.4.egg", "system.nfs4_acl", "\x00\x00\x00\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x16\x01\x87\x00\x00\x00\x06OWNER@\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x12\x00\x81\x00\x00\x00\x06GROUP@\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x12\x00\x81\x00\x00\x00\x09EVERYONE@\x00\x00", 80, 0) = -1 EIO (Input/output error)

It appears that the setxattr call is failing against fails on the ZFS volume mounted over ZFS
@behlendorf
Copy link
Contributor

Related to #4966. It's not clear why this is failing if it's being translated to a Posix ACL by the NFS kernel server as @maxximino pointed out. ZFS should be non the wiser. We're going to need to dig deeper in to exactly where the NFS server is failing.

@tuxoko
Copy link
Contributor

tuxoko commented Nov 8, 2016

@behlendorf
We need to implement inode->set_acl

@maxximino
Copy link
Contributor

It's indeed a real zfs bug - nfs4_setfacl -a A:999:rwx /mnt/ext4_over_nfs_with_acl/somefile works
nfs4_setfacl -a A:999:rwx /mnt/zfs_over_nfs_with_acl/somefile fails with -EIO

nfs4_getfacl reports correctly translated posix acl (set on the server with setfacl as posix acl)

@tuxoko
Copy link
Contributor

tuxoko commented Nov 8, 2016

@gdevenyi
Please try #5375

tuxoko added a commit to tuxoko/zfs that referenced this issue Nov 11, 2016
@tuxoko
Linux 3.14 compat: assign inode->set_acl
2ed75b9 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371 
Closes openzfs#5375
akatrevorjay pushed a commit to akatrevorjay/zfs that referenced this issue Nov 29, 2016
@tuxoko @akatrevorjay
Linux 3.14 compat: assign inode->set_acl
912007d 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371 
Closes openzfs#5375
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Jan 20, 2017
@tuxoko @behlendorf
Linux 3.14 compat: assign inode->set_acl
1448310 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371
Closes openzfs#5375
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 2, 2017
@tuxoko @behlendorf
Linux 3.14 compat: assign inode->set_acl
f241553 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371
Closes openzfs#5375
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 2, 2017
@tuxoko @behlendorf
Linux 3.14 compat: assign inode->set_acl
64e6863 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371
Closes openzfs#5375
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 2, 2017
@tuxoko @behlendorf
Linux 3.14 compat: assign inode->set_acl
889d003 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371
Closes openzfs#5375
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 2, 2017
@tuxoko @behlendorf
Linux 3.14 compat: assign inode->set_acl
3a4f33a 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371
Closes openzfs#5375
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 2, 2017
@tuxoko @behlendorf
Linux 3.14 compat: assign inode->set_acl
203b274 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371
Closes openzfs#5375
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 2, 2017
@tuxoko @behlendorf
Linux 3.14 compat: assign inode->set_acl
be0b37d 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#5371
Closes openzfs#5375
Requires-builders: style
behlendorf pushed a commit that referenced this issue Feb 3, 2017
@tuxoko @behlendorf
Linux 3.14 compat: assign inode->set_acl
42dae6d 
Linux 3.14 introduces inode->set_acl(). Normally, acl modification will come
from setxattr, which will handle by the acl xattr_handler, and we already
handles that well. However, nfsd will directly calls inode->set_acl or
return error if it doesn't exists.

Reviewed-by: Tim Chase <tim@chase2k.com>
Reviewed-by: Massimo Maggi <me@massimo-maggi.eu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes #5371
Closes #5375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tuxoko @behlendorf @maxximino @gdevenyi