Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case: reservation_013/015/016/017_pos #5714

Closed
behlendorf opened this issue Jan 31, 2017 · 0 comments
Closed

Test case: reservation_013/015/016/017_pos #5714

behlendorf opened this issue Jan 31, 2017 · 0 comments
Labels
Component: Test Suite Indicates an issue with the test framework or a test case

Comments

@behlendorf
Copy link
Contributor

System information

Type Version/Name
Distribution Name all
Distribution Version all
Linux Kernel all
Architecture all
ZFS Version 0.7.0-rc3
SPL Version 0.7.0-rc3

Describe the problem you're observing

The reservation_013/015/016/017_pos test cases rely on ksh's built in arithmetic functionality. That functionality is limited to 32-bit math. When the default size of the disks used by the test suite was increased to 4G from 2G these tests will overflow resulting in failures. Until such time as these test cases are updated to handle the larger values they should be disabled.

Describe how to reproduce the problem

./scripts/zfs-tests.sh -vx -s4G

Include any warning/errors/backtraces from the system logs

http://build.zfsonlinux.org/builders/Ubuntu%2014.04%20i686%20%28TEST%29/builds/762

Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/reservation/reservation_013_pos (run as root) [00:01] [FAIL]
16:32:46.25 ASSERTION: Reservation properties preserved across exports and imports
16:32:46.36 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs create testpool.8557/testfs1.8557
16:32:46.46 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs create testpool.8557/testfs1.8557/testfs2.8557
16:32:46.50 NOTE: space_avail=3935
16:32:46.56 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs create -V 825286656 testpool.8557/testvol31916
16:32:46.62 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs create -s -V 20632264704 testpool.8557/testvol2-31916
16:32:46.66 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=825286656 testpool.8557/testfs.8557
16:32:46.70 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=825286656 testpool.8557/testfs1.8557
16:32:46.73 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=825286656 testpool.8557/testfs1.8557/testfs2.8557
16:32:46.77 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=825286656 testpool.8557/testvol2-31916
16:32:46.89 SUCCESS: /home/behlendo/src/git/zfs/cmd/zpool/zpool export testpool.8557
16:32:47.63 SUCCESS: /home/behlendo/src/git/zfs/cmd/zpool/zpool import testpool.8557
16:32:47.80 NOTE: Performing local cleanup via log_onexit (cleanup)
16:32:47.88 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs destroy -f testpool.8557/testfs1.8557/testfs2.8557
16:32:47.97 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs destroy -f testpool.8557/testfs1.8557
16:32:48.05 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs destroy -f testpool.8557/testvol31916
16:32:48.12 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs destroy -f testpool.8557/testvol2-31916
16:32:48.16 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=none testpool.8557/testfs.8557
16:32:48.21 SUCCESS: zero_reservation testpool.8557/testfs.8557
16:32:48.21 Reservation property for testpool.8557/testvol31916 incorrect. Expected  851599360 but got 853336064.
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/reservation/reservation_014_pos (run as root) [00:00] [PASS]
16:32:48.24 ASSERTION: Verify cannot set reservation larger than quota
16:32:48.32 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs create -V 1031602176 testpool.8557/testvol519
16:32:48.37 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs create -s -V 16505757696 testpool.8557/testvol2-519
16:32:48.43 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set quota=1020160000 testpool.8557/testfs.8557
16:32:48.49 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=1072588800 testpool.8557/testfs.8557 exited 1
16:32:48.55 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set quota=none testpool.8557/testfs.8557
16:32:48.62 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=1084030976 testpool.8557/testvol519 exited 1
16:32:48.71 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=16558186496 testpool.8557/testvol2-519 exited 1
16:32:48.73 NOTE: Performing local cleanup via log_onexit (cleanup)
16:32:48.80 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs destroy -f testpool.8557/testvol519
16:32:48.87 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs destroy -f testpool.8557/testvol2-519
16:32:48.91 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set reservation=none testpool.8557/testfs.8557
16:32:48.96 SUCCESS: zero_reservation testpool.8557/testfs.8557
16:32:48.96 As expected cannot set reservation larger than quota
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/reservation/reservation_015_pos (run as root) [00:00] [FAIL]
16:32:48.99 ASSERTION: Setting volume reservation to 'none' allows more data to be  written to top level filesystem
16:32:49.05 /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/reservation/reservation_015_pos.sh[67]: largest_volsize_from_pool: line 197: :: invalid character in expression - NOTE: Performing local cleanup via log_onexit (cleanup)
16:32:49.05 The largest_volsize must be greater than volblksize.
16:32:49.09 ERROR: /home/behlendo/src/git/zfs/cmd/zfs/zfs create -V NOTE: Performing local cleanup via log_onexit (cleanup) The largest_volsize must be greater than volblksize. testpool.8557/testvol1082 exited 1
16:32:49.09 bad volume size 'NOTE:': bad numeric value 'NOTE:'
16:32:49.09 NOTE: Performing local cleanup via log_onexit (cleanup)
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/reservation/reservation_016_pos (run as root) [00:00] [FAIL]
16:32:49.13 ASSERTION: Destroying a regular volume with reservation allows more data to  be written to top level filesystem
16:32:49.20 /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/reservation/reservation_016_pos.sh[66]: largest_volsize_from_pool: line 197: :: invalid character in expression - NOTE: Performing local cleanup via log_onexit (cleanup)
16:32:49.20 The largest_volsize must be greater than volblksize.
16:32:49.24 ERROR: /home/behlendo/src/git/zfs/cmd/zfs/zfs create -V NOTE: Performing local cleanup via log_onexit (cleanup) The largest_volsize must be greater than volblksize. testpool.8557/testvol1173 exited 1
16:32:49.24 bad volume size 'NOTE:': bad numeric value 'NOTE:'
16:32:49.24 NOTE: Performing local cleanup via log_onexit (cleanup)
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/reservation/reservation_017_pos (run as root) [00:00] [FAIL]
16:32:49.28 ASSERTION: Verify that the volsize changes of sparse volumes are not  reflected in the reservation.
16:32:49.34 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs create -V 64M testpool.8557/testvol1270
16:32:49.39 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs create -s -V 64M testpool.8557/testvol2-1270
16:32:49.50 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set volsize=166150144 testpool.8557/testvol1270
16:32:49.55 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs set volsize=166150144 testpool.8557/testvol2-1270
16:32:49.67 NOTE: Performing local cleanup via log_onexit (cleanup)
16:32:49.75 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs destroy testpool.8557/testvol1270
16:32:49.83 SUCCESS: /home/behlendo/src/git/zfs/cmd/zfs/zfs destroy testpool.8557/testvol2-1270
16:32:49.83 volsize changes of regular volume is not reflected  in reservation (expected 171687936, got 173490176).
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/reservation/cleanup (run as root) [00:00] [PASS]
16:32:50.18 SUCCESS: rm -f -rf /var/tmp/testdir8557
16:32:50.19 lsblk: /dev/mapper/loop0: not a block device
@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Jan 31, 2017
behlendorf added a commit to behlendorf/zfs that referenced this issue Jan 31, 2017
@behlendorf
Refresh Linux test suite runfile
6f1a778 
The following test cases were disabled due to the increased
default disk sized used by the test suite.  The test cases
must be updated to correctly handle the larger size.

reservation_013_pos - openzfs#5714
reservation_015_pos - openzfs#5714
reservation_016_pos - openzfs#5714
reservation_017_pos - openzfs#5714

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
This was referenced Jan 31, 2017
Merged
Merged
behlendorf added a commit to openzfs/zfs-buildbot that referenced this issue Jan 31, 2017
@behlendorf
Revert "Change loop size to 4G in zfstests"
06575cd 
Reverts #53. Until the issues uncovered by increasing this default value are resolved, openzfs/zfs#5714, this change must be reverted.
@behlendorf behlendorf mentioned this issue Feb 1, 2017
Closed
behlendorf added a commit to behlendorf/zfs that referenced this issue Feb 1, 2017
@behlendorf
Fix reservation test cases for large disks
4813250 
Convert explicit `typeset -i` declarations to `typeset -l` in order
to prevent 32-bit overflow from occurs with disks >2G.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#5714

TEST_ZFSTESTS_DISKSIZE=4G
behlendorf added a commit to behlendorf/zfs that referenced this issue Feb 1, 2017
@behlendorf
Fix reservation test cases for large disks
d8e8f41 
Convert explicit `typeset -i` and `typeset -l` declarations to
`typeset` in order to prevent 32-bit overflow from occurs with
disks >2G.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#5714

TEST_ZFSTESTS_DISKSIZE=4G
behlendorf added a commit to behlendorf/zfs that referenced this issue Feb 1, 2017
@behlendorf
Fix reservation test cases for large disks
5d61ebc 
Convert explicit `typeset -i` and `typeset -l` declarations to
`typeset` in order to prevent 32-bit overflow from occurs with
disks >2G.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#5714

TEST_ZFSTESTS_DISKSIZE=4G
wli5 pushed a commit to wli5/zfs that referenced this issue Feb 28, 2017
@behlendorf @wli5
Fix reservation test cases for large disks
cdd1387 
Convert explicit `typeset -i` and `typeset -l` declarations to
`typeset` in order to prevent 32-bit overflow from occurs with
disks >2G.

TEST_ZFSTESTS_DISKSIZE=4G

Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#5715 
Closes openzfs#5714
wli5 pushed a commit to wli5/zfs that referenced this issue Feb 28, 2017
@behlendorf @wli5
Fix reservation test cases for large disks
a68279b 
Convert explicit `typeset -i` and `typeset -l` declarations to
`typeset` in order to prevent 32-bit overflow from occurs with
disks >2G.

TEST_ZFSTESTS_DISKSIZE=4G

Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#5715
Closes openzfs#5714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behlendorf