Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should "an zio" be "a zio"? #8875

Closed
bnjf opened this issue Jun 9, 2019 · 1 comment
Closed

should "an zio" be "a zio"? #8875

bnjf opened this issue Jun 9, 2019 · 1 comment

Comments

@bnjf
Copy link
Contributor

bnjf commented Jun 9, 2019 •
edited
Loading

I was reading through the file and this caught my eye. Unless the z is silent, "a zio" reads less jarringly.

https://github.com/zfsonlinux/zfs/blob/893a6d62c1895f3e3eeb660b048236571995a564/module/zfs/vdev_raidz_math.c#L475
@behlendorf
Copy link
Contributor

behlendorf commented Jun 10, 2019 •
edited
Loading

@bnjf yes, it should be "a zio". If you have a moment to open a PR it would be welcome, otherwise if you prefer I can open one with the change.

bnjf added a commit to bnjf/zfs that referenced this issue Jun 11, 2019
@bnjf
fix typo in vdev_raidz_math.c
abd0010 
As discussed in openzfs#8875
@bnjf bnjf mentioned this issue Jun 11, 2019
Merged
12 tasks
bnjf added a commit to bnjf/zfs that referenced this issue Jun 12, 2019
@bnjf
fix typo in vdev_raidz_math.c
69f65cb 
As discussed in openzfs#8875

Signed-off-by: Brad Forschinger <github@bnjf.id.au>
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 13, 2019
@bnjf @tonyhutter
Fix typo in vdev_raidz_math.c
20ece35 
Fix typo in vdev_raidz_math.c

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brad Forschinger <github@bnjf.id.au>
Closes openzfs#8875
Closes openzfs#8880
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 22, 2019
@bnjf @tonyhutter
Fix typo in vdev_raidz_math.c
913ae6b 
Fix typo in vdev_raidz_math.c

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brad Forschinger <github@bnjf.id.au>
Closes openzfs#8875
Closes openzfs#8880
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 23, 2019
@bnjf @tonyhutter
Fix typo in vdev_raidz_math.c
e576ae0 
Fix typo in vdev_raidz_math.c

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brad Forschinger <github@bnjf.id.au>
Closes openzfs#8875
Closes openzfs#8880
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Sep 17, 2019
@bnjf @tonyhutter
Fix typo in vdev_raidz_math.c
46d48b7 
Fix typo in vdev_raidz_math.c

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brad Forschinger <github@bnjf.id.au>
Closes openzfs#8875
Closes openzfs#8880
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Sep 18, 2019
@bnjf @tonyhutter
Fix typo in vdev_raidz_math.c
63fdfd9 
Fix typo in vdev_raidz_math.c

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brad Forschinger <github@bnjf.id.au>
Closes openzfs#8875
Closes openzfs#8880
tonyhutter pushed a commit that referenced this issue Sep 26, 2019
@bnjf @tonyhutter
Fix typo in vdev_raidz_math.c
fe11968 
Fix typo in vdev_raidz_math.c

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brad Forschinger <github@bnjf.id.au>
Closes #8875
Closes #8880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behlendorf @bnjf