Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leak in zpool_vdev.c check_disk function #8897

Closed
Finix1979 opened this issue Jun 13, 2019 · 1 comment
Closed

memory leak in zpool_vdev.c check_disk function #8897

Finix1979 opened this issue Jun 13, 2019 · 1 comment
Labels
good first issue Indicates a good issue for first-time contributors Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@Finix1979
Copy link
Contributor

After open the path and call blkid_get_tag_value function, should call free(value) before return

System information

Type Version/Name
Distribution Name
Distribution Version
Linux Kernel
Architecture
ZFS Version
SPL Version

Describe the problem you're observing

Describe how to reproduce the problem

Include any warning/errors/backtraces from the system logs
@behlendorf behlendorf added good first issue Indicates a good issue for first-time contributors Type: Defect Incorrect behavior (e.g. crash, hang) labels Jun 13, 2019
@c0d3z3r0
Copy link
Contributor

#8911

tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 13, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
f7b1688 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 22, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
a79022a 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 23, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
0042214 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Sep 17, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
0a39fda 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Sep 18, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
593b99d 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes openzfs#8897
Closes openzfs#8911
tonyhutter pushed a commit that referenced this issue Sep 26, 2019
@c0d3z3r0 @tonyhutter
Fix memory leak in check_disk()
2087b6c 
Reviewed-by: Allan Jude <allanjude@freebsd.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes #8897
Closes #8911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@behlendorf @c0d3z3r0 @Finix1979