Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: extend GCM assembly implementation to not require MOVBE #10025

Closed
wants to merge 3 commits into from

Conversation

adamdmoss
Copy link
Contributor

@adamdmoss adamdmoss commented Feb 19, 2020

Follow-up to #9749 since I'd started this implementation anyway.
Right now this PR exists to get into autobuild/testing - not quite ready for review etc. Will expand the PR real soon now.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #10025 into master will increase coverage by <1%.
The diff coverage is 73%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #10025    +/-   ##
========================================
+ Coverage      79%      79%   +<1%     
========================================
  Files         386      386            
  Lines      122431   122441    +10     
========================================
+ Hits        97053    97289   +236     
+ Misses      25378    25152   -226
Flag Coverage Δ
#kernel 79% <73%> (ø) ⬆️
#user 67% <73%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f244846...b10de59. Read the comment docs.

@AttilaFueloep
Copy link
Contributor

I think a have a less intrusive prototype (at least on the C side of things) which I prepared a week ago and opened a PR for in #10029 just now. Could you please have a look and tell me what you think?

I'm currently quite swamped so I couldn't find time to test this prototype and open a proper PR for it. I opened it now mainly to avoid double work. I'm afraid I won't find time to work on this in the next two or three weeks. It would be great If you could find the time to test it.

Sorry for the inconvenience.

@adamdmoss
Copy link
Contributor Author

I'll close this in favor of #10029 unless anyone particularly prefers this approach.

@behlendorf behlendorf closed this Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Work in Progress Not yet ready for general review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants