Add trim support to zpool wait #10071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallag88
force-pushed
the
zpool_wait_trim
branch
from
b166e6c to
42ee0a7
Compare
behlendorf
approved these changes
Feb 27, 2020
Manual trims fall into the category of long-running pool activities which people might want to wait synchronously for. This change adds support to 'zpool wait' for waiting for manual trim operations to complete. It also adds a '-w' flag to 'zpool trim' which can be used to turn 'zpool trim' into a synchronous operation. Signed-off-by: John Gallagher <john.gallagher@delphix.com>
jgallag88
force-pushed
the
zpool_wait_trim
branch
from
42ee0a7 to
71e407b
Compare
Codecov Report
@@ Coverage Diff @@
## master #10071 +/- ##
========================================
- Coverage 79% 79% -<1%
========================================
Files 386 386
Lines 122316 122349 +33
========================================
- Hits 97059 97005 -54
- Misses 25257 25344 +87
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
sdimitro
approved these changes
Mar 4, 2020
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Manual trims fall into the category of long-running pool activities which people might want to wait synchronously for. This change adds support to 'zpool wait' for waiting for manual trim operations to complete. It also adds a '-w' flag to 'zpool trim' which can be used to turn 'zpool trim' into a synchronous operation. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Signed-off-by: John Gallagher <john.gallagher@delphix.com> Closes openzfs#10071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#9162 added
zpool wait, which provides a mechanism for waiting synchronously for the completion of long-running pool activities such as scrubs and device removals.zpool waitdoesn't support waiting for the completion of manualtrimoperations though, since it was written initially beforetrimsupport was integrated. However, manual trims fall into the category of long-running pool activities which people might want to wait synchronously for, so this change adds the missing trim support tozpool wait.Description
With this change, users can run
zpool wait -t trim <pool>to wait for all of the vdevs in the pool with trims in progress to finish being trimmed. They can also add a-wflag to the command that starts the trim (i.e.zpool trim -w <pool>) to makezpool trimsynchronous.The logic to wait for trims to complete is implemented in a very similar manner to the logic to wait for device initialization to complete, since the interfaces for and implementations of trimming and initialization are very similar.
How Has This Been Tested?
Added tests to cover the new functionality.
Types of changes
Checklist:
Signed-off-by.