ZTS: Fix non-portable date format #10170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Component: Test Suite
ghost
requested a review
from 
jwk404
approved these changes
Apr 1, 2020
behlendorf
approved these changes
Apr 1, 2020
behlendorf
added
Status: Accepted
gmelikov
reviewed
Apr 2, 2020
The delegate tests use `date(1)` to generate snapshot names, using the format '%F-%T-%N' to get nanosecond resolution (since multiple snapshots may be taken in the same second). '%N' is not portable, and causes tests to fail on FreeBSD. Since the only purpose these timestamps serve is to create a unique name, simply use $RANDOM instead. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
|
|
LOL all the test bots failed by coincidence, but the tests did pass :P |
Codecov Report
@@ Coverage Diff @@
## master #10170 +/- ##
==========================================
+ Coverage 78.98% 79.39% +0.41%
==========================================
Files 385 385
Lines 122594 122594
==========================================
+ Hits 96831 97339 +508
+ Misses 25763 25255 -508
Continue to review full report at Codecov.
|
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The delegate tests use `date(1)` to generate snapshot names, using the format '%F-%T-%N' to get nanosecond resolution (since multiple snapshots may be taken in the same second). '%N' is not portable, and causes tests to fail on FreeBSD. Since the only purpose these timestamps serve is to create a unique name, simply use $RANDOM instead. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The delegate tests use
date(1)to generate snapshot names, usingthe format '%F-%T-%N' to get nanosecond resolution (since multiple
snapshots may be taken in the same second). '%N' is not portable, and
causes tests to fail on FreeBSD.
Description
Since the only purpose these timestamps serve is to create a unique
name, simply use $RANDOM instead.
How Has This Been Tested?
ZTS on FreeBSD
Types of changes
Checklist:
Signed-off-by.