Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARMv7 longjmp bugfix #10731

Merged

Conversation

awehrfritz
Copy link
Contributor

@awehrfritz awehrfritz commented Aug 18, 2020

Motivation and Context

Backport bugfix for ARMv7 to zfs 0.8.5, as suggested in #10722 (comment)

Description

The kernel module in the zfs 0.8-branch has been broken on the 32-bit ARMv7 platform (armhf). The issue has been reported in #9957 and fixed in #9967 (ab16c87). This PR backports the fix to the 0.8 release branch.

How Has This Been Tested?

Tested within the original PR (#9967). Furthermore, I included the patch in a local Debian package build where I apply this patch to the 0.8.4 release and use it ever since on my production system (a Helios4 based on the ARMv7 architecture).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

When a Thumb-2 kernel is being used, then longjmp must be implemented
using the Thumb-2 instruction set in module/lua/setjmp/setjmp_arm.S.

Original-patch-by: @jsrlabs
Reviewed-by: @awehrfritz
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7408 
Closes openzfs#9957 
Closes openzfs#9967
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (zfs-0.8.5-staging@6b18d7d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             zfs-0.8.5-staging   #10731   +/-   ##
====================================================
  Coverage                     ?   78.67%           
====================================================
  Files                        ?      381           
  Lines                        ?   118574           
  Branches                     ?        0           
====================================================
  Hits                         ?    93283           
  Misses                       ?    25291           
  Partials                     ?        0           
Flag Coverage Δ
#kernel 79.07% <0.00%> (?)
#user 67.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b18d7d...f981862. Read the comment docs.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 19, 2020
@tonyhutter tonyhutter merged commit b2dcf8f into openzfs:zfs-0.8.5-staging Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants