Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blkg_tryget config test: initialize struct #11049

Merged
merged 1 commit into from
Oct 13, 2020
Merged

blkg_tryget config test: initialize struct #11049

merged 1 commit into from
Oct 13, 2020

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Oct 10, 2020 •
edited
Loading

This patch fixes building on CentOS 8 Stream (next CentOS/RHEL 8 release).

Motivation and Context

Build fix, cf #10713.

Description

Missing struct initialization in a config test making the compiler not happy.

How Has This Been Tested?

This has only been tested on 0.8.x.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@MatMaul
blkg_tryget config test: initialize struct
3a9fcbc 
Signed-off-by: Mathieu Velten <matmaul@gmail.com>
@PrivatePuffin
Copy link
Contributor

Codewise this PR is fine.

Some nits:

This has only been tested on the 0.8.x
Try to test on master next time, because you are PR'ing into master.

this PR is a backport.

It isn't, please remove this for future reference. You are not backporting this in this PR, you are PR'ing into master. A PR into a staging branch would be a backport ;)

I think you meant:

This needs to be backported into 0.8.x

@MatMaul
Copy link
Contributor Author

MatMaul commented Oct 12, 2020

It's not a backport indeed, wrong wording, it was 2AM around here 😉 My point was mainly that it was not tested directly on master, I'll remove the backport part.

I would indeed however appreciate a backport on 0.8.x branch.

@MatMaul
Copy link
Contributor Author

MatMaul commented Oct 12, 2020

And sorry for not testing on master directly, I know it's the way to go but I weighed the changes was so small and unimportant that it was safe to go. But I still like to be clear about what I tested, just to be honest with people.

@PrivatePuffin
Copy link
Contributor

And sorry for not testing on master directly, I know it's the way to go but I weighed the changes was so small and unimportant that it was safe to go. But I still like to be clear about what I tested, just to be honest with people.

I agree, don't worry too much about it 👍

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 13, 2020
@behlendorf behlendorf merged commit b3a216f into openzfs:master Oct 13, 2020
behlendorf pushed a commit that referenced this pull request Oct 16, 2020
@MatMaul @behlendorf
blkg_tryget config test: initialize struct
f40a1ad 
Missing struct initialization in a config test results in the
interface being incorrectly detected.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Adam Moss <c@yotes.com>
Signed-off-by: Mathieu Velten <matmaul@gmail.com>
Closes #10713
Closes #11049
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 9, 2020
@MatMaul
blkg_tryget config test: initialize struct
b81c827 
Missing struct initialization in a config test results in the
interface being incorrectly detected.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Adam Moss <c@yotes.com>
Signed-off-by: Mathieu Velten <matmaul@gmail.com>
Closes openzfs#10713
Closes openzfs#11049
tonyhutter pushed a commit that referenced this pull request Dec 14, 2020
@MatMaul @tonyhutter
blkg_tryget config test: initialize struct
38cf54e 
Missing struct initialization in a config test results in the
interface being incorrectly detected.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Adam Moss <c@yotes.com>
Signed-off-by: Mathieu Velten <matmaul@gmail.com>
Closes #10713
Closes #11049
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@MatMaul @jsai20
blkg_tryget config test: initialize struct
a30d10e 
Missing struct initialization in a config test results in the
interface being incorrectly detected.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Adam Moss <c@yotes.com>
Signed-off-by: Mathieu Velten <matmaul@gmail.com>
Closes openzfs#10713 
Closes openzfs#11049
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@MatMaul
blkg_tryget config test: initialize struct
e1323c5 
Missing struct initialization in a config test results in the
interface being incorrectly detected.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Adam Moss <c@yotes.com>
Signed-off-by: Mathieu Velten <matmaul@gmail.com>
Closes openzfs#10713 
Closes openzfs#11049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdmoss adamdmoss adamdmoss approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatMaul @PrivatePuffin @behlendorf @adamdmoss