Makefile.bsd: remove directory that no longer exists #11077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed in a reorganization of directories preparing for the merge of FreeBSD support, 006e9a4 by mmacy. While llvm is perfectly happy with the nonexistent -I directory, the gcc6 and gcc9 we can elect to use as cross-toolchains both trip over it. Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
|
@mattmacy We don't use Makefile.bsd in the imports to provision anything in sys/conf/kmod.mk (OPENZFS_CFLAGS) or sys/modules/zfs/Makefile, right? Any objection to going ahead and committing the removal of these two instances of |
ghost
approved these changes
Oct 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #11077 +/- ##
==========================================
- Coverage 79.67% 79.39% -0.28%
==========================================
Files 397 397
Lines 125756 125756
==========================================
- Hits 100191 99844 -347
- Misses 25565 25912 +347
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Oct 20, 2020
behlendorf
added
Status: Accepted
ghost
pushed a commit
to zfsonfreebsd/ZoF
that referenced
this pull request
Oct 30, 2020
This was removed in a reorganization of directories preparing for the merge of FreeBSD support, 006e9a4 by mmacy. While llvm is perfectly happy with the nonexistent -I directory, the gcc6 and gcc9 we can elect to use as cross-toolchains both trip over it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Kyle Evans <kevans@FreeBSD.org> Closes openzfs#11077
behlendorf
pushed a commit
that referenced
this pull request
Oct 30, 2020
This was removed in a reorganization of directories preparing for the merge of FreeBSD support, 006e9a4 by mmacy. While llvm is perfectly happy with the nonexistent -I directory, the gcc6 and gcc9 we can elect to use as cross-toolchains both trip over it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Kyle Evans <kevans@FreeBSD.org> Closes #11077
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
This was removed in a reorganization of directories preparing for the merge of FreeBSD support, 006e9a4 by mmacy. While llvm is perfectly happy with the nonexistent -I directory, the gcc6 and gcc9 we can elect to use as cross-toolchains both trip over it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Kyle Evans <kevans@FreeBSD.org> Closes openzfs#11077
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
This was removed in a reorganization of directories preparing for the merge of FreeBSD support, 006e9a4 by mmacy. While llvm is perfectly happy with the nonexistent -I directory, the gcc6 and gcc9 we can elect to use as cross-toolchains both trip over it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Kyle Evans <kevans@FreeBSD.org> Closes openzfs#11077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed in a reorganization of directories preparing for the
merge of FreeBSD support, 006e9a4 by mmacy. While llvm is perfectly
happy with the nonexistent -I directory, the gcc6 and gcc9 we can elect
to use as cross-toolchains both trip over it.
Signed-off-by: Kyle Evans kevans@FreeBSD.org
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.