Use known license string for zlua #11113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Linux kernel MODULE_LICENSE macro only recognizes a handful of license strings and "MIT" is not one of the them. Update the macro to use "Dual MIT/GPL" which is recognized and what the kernel expects MIT licensed modules to use. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#11112
behlendorf
added
the
Type: Building
Codecov Report
@@ Coverage Diff @@
## master #11113 +/- ##
==========================================
- Coverage 79.56% 79.50% -0.06%
==========================================
Files 398 398
Lines 125754 125754
==========================================
- Hits 100060 99986 -74
- Misses 25694 25768 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gmelikov
approved these changes
Oct 27, 2020
|
I had to modify this commit to merge into 0.8.5-1 on my system (module macros aren't wrapped with "ZFS_" on the 0.8.y branch), but this did the trick. I'm able to run 0.8.5-1 on Ubuntu 20.04 ARM64 without errors now. Any chance we could backport this to 0.8.6 (which supports 5.9) or even a 0.8.5-2 (if it's intended to support 5.9)? |
behlendorf
added
Status: Accepted
|
Yup, we'll get it back ported for the next point release. |
ghost
pushed a commit
to zfsonfreebsd/ZoF
that referenced
this pull request
Oct 30, 2020
The Linux kernel MODULE_LICENSE macro only recognizes a handful of license strings and "MIT" is not one of the them. Update the macro to use "Dual MIT/GPL" which is recognized and what the kernel expects MIT licensed modules to use. Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#11112 Closes openzfs#11113
behlendorf
added a commit
that referenced
this pull request
Oct 30, 2020
The Linux kernel MODULE_LICENSE macro only recognizes a handful of license strings and "MIT" is not one of the them. Update the macro to use "Dual MIT/GPL" which is recognized and what the kernel expects MIT licensed modules to use. Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #11112 Closes #11113
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The Linux kernel MODULE_LICENSE macro only recognizes a handful of license strings and "MIT" is not one of the them. Update the macro to use "Dual MIT/GPL" which is recognized and what the kernel expects MIT licensed modules to use. Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#11112 Closes openzfs#11113
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
The Linux kernel MODULE_LICENSE macro only recognizes a handful of license strings and "MIT" is not one of the them. Update the macro to use "Dual MIT/GPL" which is recognized and what the kernel expects MIT licensed modules to use. Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#11112 Closes openzfs#11113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue #11112
Description
The Linux kernel MODULE_LICENSE macro only recognizes a handful of
license strings and "MIT" is not one of the them. Update the macro
to use "Dual MIT/GPL" which is recognized and what the kernel expects
MIT licensed modules to use.
How Has This Been Tested?
Manually loaded and inspected.
Types of changes
Checklist:
Signed-off-by.