Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: g/c unused zfs_znode_move support #11114

Merged
merged 1 commit into from
Oct 29, 2020
Merged

FreeBSD: g/c unused zfs_znode_move support #11114

merged 1 commit into from
Oct 29, 2020

Conversation

mjguzik
Copy link
Contributor

@mjguzik mjguzik commented Oct 26, 2020

The allocator does not provide the functionality to begin with.

Signed-off-by: Mateusz Guzik mjguzik@gmail.com

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mjguzik
FreeBSD: g/c unused zfs_znode_move support
75396de 
The allocator does not provide the functionality to begin with.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #11114 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11114      +/-   ##
==========================================
- Coverage   79.81%   79.76%   -0.05%     
==========================================
  Files         398      398              
  Lines      125754   125754              
==========================================
- Hits       100367   100312      -55     
- Misses      25387    25442      +55
Flag Coverage Δ
#kernel 80.33% <ø> (-0.14%) ⬇️
#user 66.17% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/os/linux/spl/spl-zlib.c 55.35% <0.00%> (-28.58%) ⬇️
module/os/linux/spl/spl-kmem-cache.c 78.44% <0.00%> (-11.64%) ⬇️
module/zfs/vdev_indirect.c 74.58% <0.00%> (-10.30%) ⬇️
module/zfs/vdev_raidz.c 89.35% <0.00%> (-4.57%) ⬇️
module/zfs/spa_errlog.c 90.83% <0.00%> (-3.06%) ⬇️
module/zfs/zfs_fm.c 86.02% <0.00%> (-1.53%) ⬇️
lib/libzfs/libzfs_changelist.c 85.18% <0.00%> (-1.12%) ⬇️
module/zfs/vdev_queue.c 95.28% <0.00%> (-0.89%) ⬇️
module/zfs/vdev_trim.c 95.35% <0.00%> (-0.75%) ⬇️
module/zfs/zio_checksum.c 98.31% <0.00%> (-0.57%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c810ac...75396de. Read the comment docs.

@ghost ghost self-requested a review October 27, 2020 11:41
@ghost ghost added the Status: Code Review Needed Ready for review and testing label Oct 27, 2020
@ghost ghost added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 27, 2020
@behlendorf behlendorf merged commit 082ff32 into openzfs:master Oct 29, 2020
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this pull request Oct 30, 2020
@mjguzik
FreeBSD: g/c unused zfs_znode_move support
256e76a 
The allocator does not provide the functionality to begin with.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Matt Macy <mmacy@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11114
behlendorf pushed a commit that referenced this pull request Oct 30, 2020
@mjguzik @behlendorf
FreeBSD: g/c unused zfs_znode_move support
e579a4e 
The allocator does not provide the functionality to begin with.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Matt Macy <mmacy@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #11114
@mjguzik mjguzik deleted the freebsd_znode_move branch October 30, 2020 23:45
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@mjguzik @jsai20
FreeBSD: g/c unused zfs_znode_move support
3647e7e 
The allocator does not provide the functionality to begin with.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Matt Macy <mmacy@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11114
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@mjguzik
FreeBSD: g/c unused zfs_znode_move support
63855ae 
The allocator does not provide the functionality to begin with.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Matt Macy <mmacy@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@mattmacy mattmacy mattmacy approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjguzik @behlendorf @mattmacy