FreeBSD: zvol_os: Use SET_ERROR more judiciously #11146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SET_ERROR is useful to trace errors, so use it where the errors occur rather than factored out to the end of a function. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
ghost
added
the
behlendorf
approved these changes
Nov 2, 2020
behlendorf
added
Status: Accepted
ghost
deleted the
behlendorf
pushed a commit
that referenced
this pull request
Nov 3, 2020
SET_ERROR is useful to trace errors, so use it where the errors occur rather than factored out to the end of a function. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11146
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
SET_ERROR is useful to trace errors, so use it where the errors occur rather than factored out to the end of a function. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#11146
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
SET_ERROR is useful to trace errors, so use it where the errors occur rather than factored out to the end of a function. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#11146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
SET_ERROR is useful to trace errors, so use it where the errors occur
rather than factored out to the end of a function.
How Has This Been Tested?
We have had this in the TrueNAS 12 diff for a few months now (I forgot to upstream it sooner).
Types of changes
Checklist:
Signed-off-by.