Allow different name for user data #11165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
reviewed
Nov 11, 2020
There was a problem hiding this comment.
@felixdoerre as the original author would you mind reviewing this.
felixdoerre
reviewed
Nov 11, 2020
felixdoerre
reviewed
Nov 12, 2020
felixdoerre
reviewed
Nov 13, 2020
CragW
changed the title
|
can you do something better than |
|
That is a recursive call from within a wrapper I can simplify the searching so it starts from |
felixdoerre
approved these changes
Nov 21, 2020
|
@CragW can you please rebase this on the latest version of the master branch, squash your commits, and force update the PR. |
Name of dataset for user home directory may vary from the expected
$homes_prefix/$username, if different naming scheme is being used.
We can use property mountpoint to specify the dataset for $username
as long as its value is identical to passwd's pw_dir.
For example:
NAME PROPERTY VALUE
rpool/home/myuser_123456 mountpoint /home/myuser
Signed-off-by: Crag Wang <crag0715@gmail.com>
|
Done. BIG THANKS to @behlendorf and @felixdoerre . |
behlendorf
approved these changes
Nov 22, 2020
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Nov 25, 2020
Name of dataset for user home directory may vary from the expected
$homes_prefix/$username, if different naming scheme is being used.
We can use property mountpoint to specify the dataset for $username
as long as its value is identical to passwd's pw_dir.
For example:
NAME PROPERTY VALUE
rpool/home/myuser_123456 mountpoint /home/myuser
Reviewed-by: Felix Dörre <felix@dogcraft.de>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Crag Wang <crag0715@gmail.com>
Closes #11165
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Name of dataset for user home directory may vary from the expected
$homes_prefix/$username, if different naming scheme is being used.
We can use property mountpoint to specify the dataset for $username
as long as its value is identical to passwd's pw_dir.
For example:
NAME PROPERTY VALUE
rpool/home/myuser_123456 mountpoint /home/myuser
Reviewed-by: Felix Dörre <felix@dogcraft.de>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Crag Wang <crag0715@gmail.com>
Closes openzfs#11165
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Name of dataset for user home directory may vary from the expected
$homes_prefix/$username, if different naming scheme is being used.
We can use property mountpoint to specify the dataset for $username
as long as its value is identical to passwd's pw_dir.
For example:
NAME PROPERTY VALUE
rpool/home/myuser_123456 mountpoint /home/myuser
Reviewed-by: Felix Dörre <felix@dogcraft.de>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Crag Wang <crag0715@gmail.com>
Closes openzfs#11165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, the name of dataset for each user is predicted statically, as homes_prefix e.g. rpool/home, followed by user's name e.g. rpool/home/test. However, the naming style may vary from current prediction according to users own preference.
The problem for instance, filesystem dataset rpool/home/test_123456 is given to user test as home directory to hold user data, rather than the predicted name. In this case, failure is seen due to missing rpool/home/test.
Description
Proposed change in this commit brings option prop_mountpoint to pam_zfs_key.so module. Given option will take passwd's pw_dir e.g. /home/test comparing with property mountpoint from walking through all the filesystem datasets until one has the value matched.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.