Implement memory and CPU hotplug #11212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcd1193182
requested review from
behlendorf,
prakashsurya,
ahrens and
a user
ahrens
reviewed
Nov 16, 2020
ghost
approved these changes
Nov 16, 2020
behlendorf
reviewed
Nov 17, 2020
behlendorf
reviewed
Nov 18, 2020
ahrens
reviewed
Nov 20, 2020
behlendorf
reviewed
Nov 20, 2020
behlendorf
reviewed
Dec 2, 2020
|
If you rebase this on master we should be able to get a clean run on the FreeBSD head builder. |
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
behlendorf
approved these changes
Dec 3, 2020
ahrens
reviewed
Dec 3, 2020
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
behlendorf
reviewed
Dec 8, 2020
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
behlendorf
approved these changes
Dec 8, 2020
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
ahrens
approved these changes
Dec 10, 2020
behlendorf
added
Status: Accepted
pcd1193182
added a commit
to pcd1193182/zfs
that referenced
this pull request
Dec 10, 2020
ZFS currently doesn't react to hotplugging cpu or memory into the system in any way. This patch changes that by adding logic to the ARC that allows the system to take advantage of new memory that is added for caching purposes. It also adds logic to the taskq infrastructure to support dynamically expanding the number of threads allocated to a taskq. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Co-authored-by: Matthew Ahrens <matthew.ahrens@delphix.com> Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Dagnelie <pcd@delphix.com> Closes openzfs#11212
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
ZFS currently doesn't react to hotplugging cpu or memory into the system in any way. This patch changes that by adding logic to the ARC that allows the system to take advantage of new memory that is added for caching purposes. It also adds logic to the taskq infrastructure to support dynamically expanding the number of threads allocated to a taskq. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Co-authored-by: Matthew Ahrens <matthew.ahrens@delphix.com> Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Dagnelie <pcd@delphix.com> Closes openzfs#11212
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
ZFS currently doesn't react to hotplugging cpu or memory into the system in any way. This patch changes that by adding logic to the ARC that allows the system to take advantage of new memory that is added for caching purposes. It also adds logic to the taskq infrastructure to support dynamically expanding the number of threads allocated to a taskq. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Co-authored-by: Matthew Ahrens <matthew.ahrens@delphix.com> Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Dagnelie <pcd@delphix.com> Closes openzfs#11212
|
Please correct me if I'm wrong but it sounds like this patch covers the case I had asked about here, but in a better way (supporting dynamic memory via ballooning) #10200 If so that's awesome, and I'll close out that issue! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Dagnelie pcd@delphix.com
Motivation and Context
In virtualized environments, it is common to want to adjust the resource allocation of a VM without rebooting it. Modern systems support both addition and removal of memory and CPUs, but ZFS does not. This patch adds support for hotplugging CPUs and memory to ZFS.
Description
ZFS currently doesn't react to hotplugging cpu or memory into the system in any way. This patch changes that by adding logic to the ARC that allows the system to take advantage of new memory that is added for caching purposes. It also adds logic to the taskq infrastructure to support dynamically expanding the number of threads allocated to a taskq.
How Has This Been Tested?
The zfs test suite and zloop have been run against this patch, both before and after hotplugging cpu and memory.
Types of changes
Checklist:
Signed-off-by.