Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity.run file #11271

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Add sanity.run file #11271

merged 1 commit into from
Dec 3, 2020

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Provide a cut down version of the common.run file which can be
used to relatively quickly assess all core functionality.

Description

This run file contains a subset of functional tests which exercise
as much functionality as possible while still executing relatively
quickly. The included tests should take no more than a few seconds
each to run at most. This provides a convenient way to sanity test a
change before commiting to a full test run which takes several hours.

$ ./scripts/zfs-tests.sh -r sanity
...
Results Summary
PASS	 813

Running Time:	00:14:42
Percent passed:	100.0%

How Has This Been Tested?

Locally ran the ZTS using the new sanity.run file. Verified all
tests pass and the run time is approximately 15 minutes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Dec 3, 2020
@behlendorf behlendorf requested a review from a user December 3, 2020 04:34
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 3, 2020
This run file contains a subset of functional tests which exercise
as much functionality as possible while still executing relatively
quickly.  The included tests should take no more than a few seconds
each to run at most.  This provides a convenient way to sanity test a
change before commiting to a full test run which takes several hours.

    $ ./scripts/zfs-tests.sh -r sanity
    ...
    Results Summary
    PASS	 813

    Running Time:	00:14:42
    Percent passed:	100.0%

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
TEST_ZFSTESTS_RUNFILE="sanity.run"
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting idea, though maintaining it may be a bit of a chore.
I have no objection to letting this in as is, but a future idea that could be investigated is removing these tests from common.run and making that something like extended.run. It would be nice to be able to have both running at the same time.

@behlendorf
Copy link
Contributor Author

That's definitely a concern I share. However, since this new run file isn't intended to replace the existing ones it really doesn't need to provide complete coverage. That should help minimize the maintenance burden. My hope was simply to provide something which could be run quickly and perform a reasonable sanity check that things are working correctly. Regarding moving these tests out of the common.run or somehow splitting it up further I think is an idea worth exploring in the future.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 3, 2020
@behlendorf behlendorf merged commit 8f158ae into openzfs:master Dec 3, 2020
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this pull request Dec 23, 2020
This run file contains a subset of functional tests which exercise
as much functionality as possible while still executing relatively
quickly.  The included tests should take no more than a few seconds
each to run at most.  This provides a convenient way to sanity test a
change before committing to a full test run which takes several hours.

    $ ./scripts/zfs-tests.sh -r sanity
    ...
    Results Summary
    PASS	 813

    Running Time:	00:14:42
    Percent passed:	100.0%

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#11271
behlendorf added a commit that referenced this pull request Dec 23, 2020
This run file contains a subset of functional tests which exercise
as much functionality as possible while still executing relatively
quickly.  The included tests should take no more than a few seconds
each to run at most.  This provides a convenient way to sanity test a
change before committing to a full test run which takes several hours.

    $ ./scripts/zfs-tests.sh -r sanity
    ...
    Results Summary
    PASS	 813

    Running Time:	00:14:42
    Percent passed:	100.0%

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #11271
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
This run file contains a subset of functional tests which exercise
as much functionality as possible while still executing relatively
quickly.  The included tests should take no more than a few seconds
each to run at most.  This provides a convenient way to sanity test a
change before committing to a full test run which takes several hours.

    $ ./scripts/zfs-tests.sh -r sanity
    ...
    Results Summary
    PASS	 813

    Running Time:	00:14:42
    Percent passed:	100.0%

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#11271
@behlendorf behlendorf deleted the zts-sanity branch April 19, 2021 19:21
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
This run file contains a subset of functional tests which exercise
as much functionality as possible while still executing relatively
quickly.  The included tests should take no more than a few seconds
each to run at most.  This provides a convenient way to sanity test a
change before committing to a full test run which takes several hours.

    $ ./scripts/zfs-tests.sh -r sanity
    ...
    Results Summary
    PASS	 813

    Running Time:	00:14:42
    Percent passed:	100.0%

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#11271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant